From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org, mfe@pengutronix.de
Subject: Re: [PATCH] usbgadget: autostart: add usbgadget_autostart helper for board code
Date: Wed, 17 Aug 2022 09:10:42 +0200 [thread overview]
Message-ID: <20220817071042.GR17485@pengutronix.de> (raw)
In-Reply-To: <80d3e34a-37aa-1d04-ff21-5ccd7a9cadc4@pengutronix.de>
On Wed, Aug 17, 2022 at 08:30:10AM +0200, Ahmad Fatoum wrote:
> Hello Sascha,
>
> On 16.08.22 09:57, Sascha Hauer wrote:
> > The code is a bit hard to follow with the approach of starting the
> > gadget exclusively from the setter function of global.usbgadget.autostart
> >
> > Can we go with the following approach? It moves the starting of the usb
> > gadget to a function that first checks if all prerequisites are
> > fulfilled to start the gadget and then starts it if desired.
>
> Just tested it and works for me. Please apply.
Did that.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2022-08-17 7:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 9:17 Ahmad Fatoum
2022-08-16 7:57 ` Sascha Hauer
2022-08-17 6:30 ` Ahmad Fatoum
2022-08-17 7:10 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817071042.GR17485@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=mfe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox