Re: [PATCH 4/8] state: cosmetic fix reverse christmas tree order

[Sascha Hauer <sha@pengutronix.de>]

On Fri, Oct 14, 2022 at 06:35:30PM +0200, Marco Felsch wrote:
> No functional change, just apply the common code standards.

I didn't know these are common code standards for barebox ;)

Also I really don't like such things very much. The following forces you
to violate this rule:

	struct priv *priv = to_priv(common_type);
	struct myfoo = &priv->some_special_thingy_inside_priv;

>  		return 0;
> @@ -212,13 +212,13 @@ static int state_convert_node_variable(struct state *state,
>  				       const char *parent_name,
>  				       enum state_convert conv)
>  {
> +	struct device_node *new_node = NULL;
>  	const struct variable_type *vtype;
> +	char *short_name, *name, *indexs;

If you add another char * type variable or remove one of those you
either violate the ordering or introduce another useless churn.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |