* [PATCH] ARM: rk356x: rk3568-evb: add missing new line to log message
@ 2022-11-02 10:48 Ahmad Fatoum
2022-11-04 8:53 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2022-11-02 10:48 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
If ADC is available, but read out returns an error, we end up with a log
line that's not new line terminated. Fix this.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
arch/arm/boards/rockchip-rk3568-evb/board.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boards/rockchip-rk3568-evb/board.c b/arch/arm/boards/rockchip-rk3568-evb/board.c
index 212c801c93d3..ef886e67ed15 100644
--- a/arch/arm/boards/rockchip-rk3568-evb/board.c
+++ b/arch/arm/boards/rockchip-rk3568-evb/board.c
@@ -94,7 +94,7 @@ static int rk3568_evb_detect_hwid(void)
return 0;
err_hwid:
- pr_err("couldn't retrieve hardware ID");
+ pr_err("couldn't retrieve hardware ID\n");
return ret;
}
late_initcall(rk3568_evb_detect_hwid);
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: rk356x: rk3568-evb: add missing new line to log message
2022-11-02 10:48 [PATCH] ARM: rk356x: rk3568-evb: add missing new line to log message Ahmad Fatoum
@ 2022-11-04 8:53 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-11-04 8:53 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Wed, Nov 02, 2022 at 11:48:14AM +0100, Ahmad Fatoum wrote:
> If ADC is available, but read out returns an error, we end up with a log
> line that's not new line terminated. Fix this.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> arch/arm/boards/rockchip-rk3568-evb/board.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/boards/rockchip-rk3568-evb/board.c b/arch/arm/boards/rockchip-rk3568-evb/board.c
> index 212c801c93d3..ef886e67ed15 100644
> --- a/arch/arm/boards/rockchip-rk3568-evb/board.c
> +++ b/arch/arm/boards/rockchip-rk3568-evb/board.c
> @@ -94,7 +94,7 @@ static int rk3568_evb_detect_hwid(void)
> return 0;
>
> err_hwid:
> - pr_err("couldn't retrieve hardware ID");
> + pr_err("couldn't retrieve hardware ID\n");
> return ret;
> }
> late_initcall(rk3568_evb_detect_hwid);
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-04 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 10:48 [PATCH] ARM: rk356x: rk3568-evb: add missing new line to log message Ahmad Fatoum
2022-11-04 8:53 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox