From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 02 Dec 2022 11:54:22 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p13gR-008RKD-Eh for lore@lore.pengutronix.de; Fri, 02 Dec 2022 11:54:22 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p13gQ-0004mg-C3 for lore@pengutronix.de; Fri, 02 Dec 2022 11:54:19 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=niP4BspKAH+ime1eD2juzR87krcYGGm8fQup23c2B8M=; b=1Gsmrd3Qjp8NiI l5DYbumyJspSwMBXFDm72YhHtpkVMYfhT47ZBxGtbxrLgrchEoXBmo+rIUGN7bJnsj8bKZ2h/uuc5 9UlSCZAyvdJMmFhMIEcTXuOVxvTg2LbmeerngBnCD+lJEbUXLeFuPMpAnFolFwuQkdxyZDocB7k33 NGzSVMFfFaew41QbEQDawGPm4l5Ckco0aItrwyIzFEcZ5rXXXCyL8EJBM3eEqyeN9ZkKg9yqtJXzv EAXR7SafnD9YbrsfDwpur29wex2SDQIuiK5QagclUO93p1y5vtQ7YEbDACjRHtHqhGusluB7jd6i0 80rUsEH7h45K1592KBZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13ed-00FkCs-2q; Fri, 02 Dec 2022 10:52:27 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13eO-00Fk5v-PX for barebox@lists.infradead.org; Fri, 02 Dec 2022 10:52:18 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p13eK-0004UX-50; Fri, 02 Dec 2022 11:52:08 +0100 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1p13eI-001mW7-PE; Fri, 02 Dec 2022 11:52:07 +0100 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1p13eI-00Cug3-QN; Fri, 02 Dec 2022 11:52:06 +0100 From: Sascha Hauer To: Barebox List Date: Fri, 2 Dec 2022 11:52:04 +0100 Message-Id: <20221202105204.3076891-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_025212_859476_4D2CD314 X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ahmad Fatoum Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] net: bcmgenet: Fix MAC address setting X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) bcmgenet_set_hwaddr() only copies the MAC address only into internal state, but not into hardware. Copying to hardware is done in __bcmgenet_set_hwaddr() called during open time. Depending on nv.dev.eth0.ethaddr being set the order in which both functions are called changes. Copy the state into hardware as well in bcmgenet_set_hwaddr(). This fixes sending packets when nv.dev.eth0.ethaddr is not set. Signed-off-by: Sascha Hauer --- drivers/net/bcmgenet.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/bcmgenet.c b/drivers/net/bcmgenet.c index 79514dfa69..8df5fd5dea 100644 --- a/drivers/net/bcmgenet.c +++ b/drivers/net/bcmgenet.c @@ -215,15 +215,6 @@ static void bcmgenet_umac_reset(struct bcmgenet_eth_priv *priv) writel(1, (priv->mac_reg + RBUF_TBUF_SIZE_CTRL)); } -static int bcmgenet_set_hwaddr(struct eth_device *dev, const unsigned char *addr) -{ - struct bcmgenet_eth_priv *priv = dev->priv; - - memcpy(priv->addr, addr, 6); - - return 0; -} - static int __bcmgenet_set_hwaddr(struct bcmgenet_eth_priv *priv) { const unsigned char *addr = priv->addr; @@ -238,6 +229,17 @@ static int __bcmgenet_set_hwaddr(struct bcmgenet_eth_priv *priv) return 0; } +static int bcmgenet_set_hwaddr(struct eth_device *dev, const unsigned char *addr) +{ + struct bcmgenet_eth_priv *priv = dev->priv; + + memcpy(priv->addr, addr, 6); + + __bcmgenet_set_hwaddr(priv); + + return 0; +} + static int bcmgenet_get_hwaddr(struct eth_device *edev, unsigned char *mac) { return -1; -- 2.30.2