From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 11 Jan 2023 11:38:56 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pFYVU-008jUl-R9 for lore@lore.pengutronix.de; Wed, 11 Jan 2023 11:38:56 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFYVS-0008JC-Q5 for lore@pengutronix.de; Wed, 11 Jan 2023 11:38:55 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CuOiutNA7BKRSTUI8MvS79aRYFtG2xzqoqv5lDaOxRs=; b=2TZil8/nkqNuILAt6qkIdXV31I mq1pmkLoJ55FVv5vwmoKLYt8xyadYJaKu4ZvCIVR/cwE1kl5QH6lv/SCnZczbvPYcImuL7sBFj1Vk iEwx8mGsly0J+2DLpJg/PM/YMDRLKtjjn0qkvg81nuxnFdt8qa5fm7ZPGfCWFcXpFK24mjDkKQuWm Kad0NsWJikja8QcL4g6OvOEujL/HPYvw5JSo4Z/GZVxrzAZCVLfjcjBPw9ym3WFD8RlfbVAWFe8mX GE5otJZJTrPwgjathKKc2UiGMcDXtVJuGN+UhoYv8EON4NWKz5YouIL5g4YlcVDyp5Y44Nv4eVvGF Vnbwz6pQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFYU8-00ApuU-39; Wed, 11 Jan 2023 10:37:32 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFYU3-00Apsm-Dv for barebox@lists.infradead.org; Wed, 11 Jan 2023 10:37:28 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFYU1-0008CZ-Fp; Wed, 11 Jan 2023 11:37:25 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pFYU1-0007w0-1W; Wed, 11 Jan 2023 11:37:25 +0100 Date: Wed, 11 Jan 2023 11:37:25 +0100 To: Ahmad Fatoum Cc: barebox@lists.infradead.org, Sam Ravnborg Message-ID: <20230111103725.GA23347@pengutronix.de> References: <20230109130822.1657470-1-a.fatoum@pengutronix.de> <20230109130822.1657470-4-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230109130822.1657470-4-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_023727_487010_8B3B23D8 X-CRM114-Status: GOOD ( 19.85 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 03/11] ARM: at91: sama5d4: enable for DT use X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Mon, Jan 09, 2023 at 02:08:14PM +0100, Ahmad Fatoum wrote: > The sama5d4[devices].c files are for non-OF instantiation of platform > devices. We don't need anything out of these two files, so don't build > them when compiling for CONFIG_OFDEVICE. > > Acked-by: Sam Ravnborg > Signed-off-by: Ahmad Fatoum > --- > arch/arm/mach-at91/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile > index 390d49d03dee..b9fda00b2e1a 100644 > --- a/arch/arm/mach-at91/Makefile > +++ b/arch/arm/mach-at91/Makefile > @@ -30,6 +30,7 @@ obj-$(CONFIG_SOC_AT91SAM9G10) += at91sam9261.o at91sam9261_devices.o > ifeq ($(CONFIG_OFDEVICE),) > obj-$(CONFIG_SOC_AT91SAM9263) += at91sam9263.o at91sam9263_devices.o > obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o sama5d3_devices.o > +obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o sama5d4_devices.o > endif > lwl-$(CONFIG_SOC_AT91SAM9263) += sam9263_ll.o > lwl-$(CONFIG_SOC_SAMA5D2) += sama5d2_ll.o > @@ -39,4 +40,3 @@ obj-$(CONFIG_SOC_AT91SAM9G20) += at91sam9260.o at91sam9260_devices.o > obj-$(CONFIG_SOC_AT91SAM9G45) += at91sam9g45.o at91sam9g45_devices.o > obj-$(CONFIG_SOC_AT91SAM9X5) += at91sam9x5.o at91sam9x5_devices.o > obj-$(CONFIG_SOC_AT91SAM9N12) += at91sam9n12.o at91sam9n12_devices.o > -obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o sama5d4_devices.o This breaks compilation of sama5d4ek_defconfig and sama5d4_xplained_defconfig: arch/arm/boards/sama5d4_xplained/sama5d4_xplained.o: in function `sama5d4_xplained_mem_init': arch/arm/boards/sama5d4_xplained/sama5d4_xplained.c:251: undefined reference to `at91_add_device_sdram' Several more undefined references follow. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |