mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: eth: skip opening disabled interfaces when going interactive
Date: Fri, 20 Jan 2023 08:38:32 +0100	[thread overview]
Message-ID: <20230120073832.GJ24755@pengutronix.de> (raw)
In-Reply-To: <20230117094934.3770899-1-a.fatoum@pengutronix.de>

On Tue, Jan 17, 2023 at 10:49:34AM +0100, Ahmad Fatoum wrote:
> Ethernet device global mode (ethX.mode) may be set to disabled when
> ports should not be used. This setting is already respect in ifup, so do
> likewise for eth_open_all(), which is called when going interactive.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  net/eth.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/net/eth.c b/net/eth.c
> index 863d0a046657..6fb64afea024 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -535,8 +535,11 @@ void eth_open_all(void)
>  {
>  	struct eth_device *edev;
>  
> -	list_for_each_entry(edev, &netdev_list, list)
> +	list_for_each_entry(edev, &netdev_list, list) {
> +		if (edev->global_mode == ETH_MODE_DISABLED)
> +			continue;
>  		eth_open(edev);
> +	}
>  }
>  
>  static int of_populate_ethaddr(void)
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2023-01-20  7:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17  9:49 Ahmad Fatoum
2023-01-20  7:38 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230120073832.GJ24755@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox