mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] i2c: i.MX: Use better error code when bus recovery failed
Date: Wed, 25 Jan 2023 10:21:29 +0100	[thread overview]
Message-ID: <20230125092129.nua7ipc223llsanv@pengutronix.de> (raw)
In-Reply-To: <20230125073739.1992152-1-s.hauer@pengutronix.de>

On 23-01-25, Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/i2c/busses/i2c-imx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index e4b04327ee..3be3b158c7 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -235,7 +235,7 @@ static int i2c_fsl_start(struct i2c_adapter *adapter)
>  	if (result) {
>  		result = i2c_recover_bus(&i2c_fsl->adapter);
>  		if (result)
> -			return result;
> +			return -EIO;

This would also reinterpret adap->bus_recovery_info->recover_bus()
errors. I didn't checked the possible error codes for this but I think
to say it's an IO error is fine.

Acked-by: Marco Felsch <m.felsch@pengutronix.de>

Regards,
  Marco

>  		return -EAGAIN;
>  	}
>  
> -- 
> 2.30.2
> 
> 
> 



  parent reply	other threads:[~2023-01-25  9:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25  7:37 Sascha Hauer
2023-01-25  7:37 ` [PATCH 2/2] i2c: Make i2c_recover_bus() to return -EBUSY if bus recovery unimplemented Sascha Hauer
2023-01-25  9:21   ` Marco Felsch
2023-01-25  9:21 ` Marco Felsch [this message]
2023-01-25  9:41   ` [PATCH 1/2] i2c: i.MX: Use better error code when bus recovery failed Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230125092129.nua7ipc223llsanv@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox