mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: John Watts <contact@jookia.org>
Cc: Marco Felsch <m.felsch@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH v2] ARM: i.MX6: Specify OCRAM base address and size
Date: Mon, 30 Jan 2023 09:08:01 +0100	[thread overview]
Message-ID: <20230130080801.GO13319@pengutronix.de> (raw)
In-Reply-To: <Y9ORygZa/PBo2ucN@novena-choice-citizen>

On Fri, Jan 27, 2023 at 07:56:42PM +1100, John Watts wrote:
> On Fri, Jan 27, 2023 at 09:06:33AM +0100, Marco Felsch wrote:
> > Hi John,
> > 
> > On 23-01-27, John Watts wrote:
> > > The i.MX6 includes some on-chip RAM: 128KiB on most variants, with 256KiB on
> > > the Dual and Quad variants.
> > > 
> > > This region is where the first stage of Barebox gets loaded if RAM
> > > initialization isn't hard coded using DCD information.
> > > 
> > > Add the base address and size so it can be used to calculate where to put the
> > > stack at boot.
> > > 
> > > Signed-off-by: John Watts <contact@jookia.org>
> > 
> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> 
> Do I add that to a V3? :)

No. I collect the Reviewed-by tags while applying. Or better, git b4
does this automatically for me ;)

> Should I add the review stuff to my Novena patches too?

Usually when sending a new series you add the tags you got from the
previous one, but just adding tags is not a reason for resending.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2023-01-30 18:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 18:36 [PATCH] " John Watts
2023-01-26 18:45 ` Marco Felsch
2023-01-26 19:02 ` [PATCH v2] " John Watts
2023-01-27  8:06   ` Marco Felsch
2023-01-27  8:56     ` John Watts
2023-01-30  8:08       ` Sascha Hauer [this message]
2023-01-30  8:08   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230130080801.GO13319@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=contact@jookia.org \
    --cc=m.felsch@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox