mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] RISC-V: virt: riscvemu: fix unit address in node name
@ 2023-02-02 14:20 Ahmad Fatoum
  2023-02-02 14:41 ` Marco Felsch
  2023-02-03  8:02 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2023-02-02 14:20 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum, Marco Felsch

The overlay adds a SRAM at address 0x1000, but the unit address was
still 0, which is confusing. Change it to sram@1000 instead.

Reported-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 arch/riscv/boards/riscvemu/overlay-of-sram.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/boards/riscvemu/overlay-of-sram.dts b/arch/riscv/boards/riscvemu/overlay-of-sram.dts
index 506d45bde9b6..092fb02518b9 100644
--- a/arch/riscv/boards/riscvemu/overlay-of-sram.dts
+++ b/arch/riscv/boards/riscvemu/overlay-of-sram.dts
@@ -9,7 +9,7 @@
 		__overlay__ {
 			#address-cells = <2>;
 			#size-cells = <2>;
-			sram@0 {
+			sram@1000 {
 				compatible = "mtd-ram";
 				reg = <0 0x1000 0 0x10000>;
 				#address-cells = <1>;
@@ -49,7 +49,7 @@ fixed-partitions
 		__overlay__ {
 			environment {
 				compatible = "barebox,environment";
-				device-path = "/soc/sram@0/partitions/partition@3000";
+				device-path = "/soc/sram@1000/partitions/partition@3000";
 			};
 		};
 	};
-- 
2.38.1




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] RISC-V: virt: riscvemu: fix unit address in node name
  2023-02-02 14:20 [PATCH] RISC-V: virt: riscvemu: fix unit address in node name Ahmad Fatoum
@ 2023-02-02 14:41 ` Marco Felsch
  2023-02-03  8:02 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Marco Felsch @ 2023-02-02 14:41 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On 23-02-02, Ahmad Fatoum wrote:
> The overlay adds a SRAM at address 0x1000, but the unit address was
> still 0, which is confusing. Change it to sram@1000 instead.
> 
> Reported-by: Marco Felsch <m.felsch@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] RISC-V: virt: riscvemu: fix unit address in node name
  2023-02-02 14:20 [PATCH] RISC-V: virt: riscvemu: fix unit address in node name Ahmad Fatoum
  2023-02-02 14:41 ` Marco Felsch
@ 2023-02-03  8:02 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2023-02-03  8:02 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox, Marco Felsch

On Thu, Feb 02, 2023 at 03:20:00PM +0100, Ahmad Fatoum wrote:
> The overlay adds a SRAM at address 0x1000, but the unit address was
> still 0, which is confusing. Change it to sram@1000 instead.
> 
> Reported-by: Marco Felsch <m.felsch@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  arch/riscv/boards/riscvemu/overlay-of-sram.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/riscv/boards/riscvemu/overlay-of-sram.dts b/arch/riscv/boards/riscvemu/overlay-of-sram.dts
> index 506d45bde9b6..092fb02518b9 100644
> --- a/arch/riscv/boards/riscvemu/overlay-of-sram.dts
> +++ b/arch/riscv/boards/riscvemu/overlay-of-sram.dts
> @@ -9,7 +9,7 @@
>  		__overlay__ {
>  			#address-cells = <2>;
>  			#size-cells = <2>;
> -			sram@0 {
> +			sram@1000 {
>  				compatible = "mtd-ram";
>  				reg = <0 0x1000 0 0x10000>;
>  				#address-cells = <1>;
> @@ -49,7 +49,7 @@ fixed-partitions
>  		__overlay__ {
>  			environment {
>  				compatible = "barebox,environment";
> -				device-path = "/soc/sram@0/partitions/partition@3000";
> +				device-path = "/soc/sram@1000/partitions/partition@3000";
>  			};
>  		};
>  	};
> -- 
> 2.38.1
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-02-03  8:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-02 14:20 [PATCH] RISC-V: virt: riscvemu: fix unit address in node name Ahmad Fatoum
2023-02-02 14:41 ` Marco Felsch
2023-02-03  8:02 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox