From: Maxim Kochetkov <fido_max@inbox.ru>
To: barebox@lists.infradead.org
Cc: pmamonov@gmail.com, a.kuyan@yadro.com, p.mamonov@yadro.com,
Maxim Kochetkov <fido_max@inbox.ru>,
Maxim Kochetkov <m.kochetkov@yadro.com>
Subject: [PATCH v3 1/1] serial: ns16550: move iomem/ioport init after clock init
Date: Fri, 17 Feb 2023 17:20:06 +0300 [thread overview]
Message-ID: <20230217142006.60228-1-fido_max@inbox.ru> (raw)
While probing ns16550 clock provider may be unavailable and
clk_get() returns -EPROBE_DEFER. Next ns16550_probe() attempts
will be failed too because of dev_request_mem_resource() has already
acquired this resource for the device and returns -EBUSY.
So move resource allocation just after clock init. It will let proper
probe for defered clocks on boards with deep probe disabled.
Signed-off-by: Maxim Kochetkov <m.kochetkov@yadro.com>
Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
---
drivers/serial/serial_ns16550.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
index 16f3576645..9ce4feed43 100644
--- a/drivers/serial/serial_ns16550.c
+++ b/drivers/serial/serial_ns16550.c
@@ -479,13 +479,6 @@ static int ns16550_probe(struct device *dev)
priv = xzalloc(sizeof(*priv));
- ret = ns16550_init_iomem(dev, priv);
- if (ret)
- ret = ns16550_init_ioport(dev, priv);
-
- if (ret)
- return ret;
-
if (plat)
priv->plat = *plat;
else
@@ -511,6 +504,13 @@ static int ns16550_probe(struct device *dev)
goto err;
}
+ ret = ns16550_init_iomem(dev, priv);
+ if (ret)
+ ret = ns16550_init_ioport(dev, priv);
+
+ if (ret)
+ goto err;
+
cdev = &priv->cdev;
cdev->dev = dev;
cdev->tstc = ns16550_tstc;
--
2.38.1
next reply other threads:[~2023-02-17 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 14:20 Maxim Kochetkov [this message]
2023-02-17 14:23 ` Ahmad Fatoum
2023-02-21 10:28 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217142006.60228-1-fido_max@inbox.ru \
--to=fido_max@inbox.ru \
--cc=a.kuyan@yadro.com \
--cc=barebox@lists.infradead.org \
--cc=m.kochetkov@yadro.com \
--cc=p.mamonov@yadro.com \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox