From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] sandbox: Fix fixing linker warnings with newer ld
Date: Tue, 21 Feb 2023 16:46:01 +0100 [thread overview]
Message-ID: <20230221154601.GK10447@pengutronix.de> (raw)
In-Reply-To: <d5492217-50c4-e25d-99f2-fe24740ac397@pengutronix.de>
On Tue, Feb 21, 2023 at 04:27:37PM +0100, Ahmad Fatoum wrote:
> Hello Sascha,
>
> On 21.02.23 16:24, Sascha Hauer wrote:
> > There must be a comma between the words passed in the -Wl option,
> > otherwise gcc responds with:
> >
> > gcc: error: noexecstack: No such file or directory
> >
> > Also cc-option only compiles but doesn't link, so can't detect if the
> > linker accepts flags or not. Use ld-option instead.
> >
> > Fixes: 4e8713dd6e ("sandbox: fix linker warnings with newer ld")
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > arch/sandbox/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/sandbox/Makefile b/arch/sandbox/Makefile
> > index 0f59e79e13..9d5a5d8c6a 100644
> > --- a/arch/sandbox/Makefile
> > +++ b/arch/sandbox/Makefile
> > @@ -69,7 +69,7 @@ BAREBOX_LDFLAGS += \
> > -Wl,-T,$(BAREBOX_LDS) \
> > -Wl,--whole-archive $(BAREBOX_OBJS) -Wl,--no-whole-archive \
> > -lrt -pthread $(SDL_LIBS) $(FTDI1_LIBS) \
> > - -Wl,-z noexecstack $(call cc-option,-Wl$(comma)--no-warn-rwx-segments) \
> > + -Wl,-z,noexecstack $(call ld-option,--no-warn-rwx-segments) \
>
> At least gcc version 11.3.0 wouldn't like this:
>
> $ gcc --no-warn-rwx-segments
> gcc: error: unrecognized command-line option ‘--no-warn-rwx-segments’
Makes sense, as we are calling $(CC) for linking.
For now I'll revert the original patch.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-02-21 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 15:24 Sascha Hauer
2023-02-21 15:27 ` Ahmad Fatoum
2023-02-21 15:46 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221154601.GK10447@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox