From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 7/8] ARM: dts: imx7d-peb-eval-02: Fix dtc warnings
Date: Thu, 2 Mar 2023 11:49:53 +0100 [thread overview]
Message-ID: <20230302104953.p45jyi6qmg4bzg2v@pengutronix.de> (raw)
In-Reply-To: <20230302103943.939422-8-s.hauer@pengutronix.de>
Hi Sascha,
On 23-03-02, Sascha Hauer wrote:
> Some nodes have a unit name, but no reg property. Drop the unit name
> to avoid dtc warnings.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm/dts/imx7d-peb-eval-02.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/dts/imx7d-peb-eval-02.dtsi b/arch/arm/dts/imx7d-peb-eval-02.dtsi
> index 8bde5b13e7..5c2c302d54 100644
> --- a/arch/arm/dts/imx7d-peb-eval-02.dtsi
> +++ b/arch/arm/dts/imx7d-peb-eval-02.dtsi
> @@ -13,21 +13,21 @@
> pinctrl-0 = <&pinctrl_leds_eval>;
> status = "disabled";
>
> - led@0 {
> + led0 {
To follow the binding doc the name should be led-0. For the below nodes
as well.
Regards,
Marco
> label = "eval_led_1";
> gpios = <&gpio2 8 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "gpio";
> default-state = "on";
> };
>
> - led@1 {
> + led1 {
> label = "eval_led_2";
> gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "gpio";
> default-state = "on";
> };
>
> - led@2 {
> + led2 {
> label = "eval_led_3";
> gpios = <&gpio2 15 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "gpio";
> @@ -41,18 +41,18 @@
> pinctrl-0 = <&pinctrl_btns_eval>;
> status = "disabled";
>
> - userbtn@0 {
> + userbtn0 {
> label = "eval_button_1";
> gpios = <&gpio2 9 GPIO_ACTIVE_HIGH>;
> linux,code = <0x100>; /* BTN_MISC */
> };
> - userbtn@1 {
> + userbtn1 {
> label = "eval_button_2";
> gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>;
> linux,code = <0x100>; /* BTN_MISC */
> };
>
> - userbtn@2 {
> + userbtn2 {
> label = "eval_button_3";
> gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>;
> linux,code = <0x100>; /* BTN_MISC */
> --
> 2.30.2
>
>
>
next prev parent reply other threads:[~2023-03-02 10:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 10:39 [PATCH 0/8] Fix/avoid " Sascha Hauer
2023-03-02 10:39 ` [PATCH 1/8] scripts: dtc: disable interrupt_provider warnings Sascha Hauer
2023-03-02 10:39 ` [PATCH 2/8] ARM: dts: digic4: Fix dtc warnings Sascha Hauer
2023-03-02 10:39 ` [PATCH 3/8] ARM: dts: ep7212-clep7212: " Sascha Hauer
2023-03-02 10:39 ` [PATCH 4/8] ARM: dts: Fix dtc warnings in state nodes Sascha Hauer
2023-03-02 10:39 ` [PATCH 5/8] ARM: dts: Fix dtc warnings in barebox,environment nodes Sascha Hauer
2023-03-02 10:39 ` [PATCH 6/8] ARM: dts: imx7d-peb-av-02: Fix dtc warning Sascha Hauer
2023-03-02 10:39 ` [PATCH 7/8] ARM: dts: imx7d-peb-eval-02: Fix dtc warnings Sascha Hauer
2023-03-02 10:49 ` Marco Felsch [this message]
2023-03-02 10:57 ` Sascha Hauer
2023-03-02 11:17 ` Marco Felsch
2023-03-02 10:39 ` [PATCH 8/8] ARM: dts: imx6ull-jozacp: Move regulators out of subnode Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302104953.p45jyi6qmg4bzg2v@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox