From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 10 Mar 2023 10:43:59 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1paZI6-00FvhE-32 for lore@lore.pengutronix.de; Fri, 10 Mar 2023 10:43:58 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paZI5-0006ju-TI for lore@pengutronix.de; Fri, 10 Mar 2023 10:43:58 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pglAhf1mE+dK5P5bp/3iyMrfPz/EjSusjwQVceckNxM=; b=TNR/2NRFNByFpwaVtVTjKAxf4d wjVjKbOOo2m5KJ2MmL/AMMmC3GJqCYRufekxlu36+s/I3oDhuRZkZ9MNOTrIGXuQj1lVtN5SX9k4H dKNMdLPkT9vt7h+uY+YyH9xPE8eEnVV+/vCExoTHa9Sq8WgOxIreIr5Ie68EByuVxgRJPO0VEAZo5 Y9M2SPMeygUWMcy/56csS8a3Q4WC/YlJAE+LnA91QQ+SoeIOoEit0nOLnRvBc41dKu4lZjtNqDB6u SK7GTz861ThZmcM/eaVAhVIRWlW5lQ4lpuQPoiGk/PXxcwt/Nl9Px3pgJw1UrfwztfdQ69qX5Ui6g MKLQQ90g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paZGn-00Dz9V-SR; Fri, 10 Mar 2023 09:42:37 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paZGd-00Dz4d-Jx for barebox@lists.infradead.org; Fri, 10 Mar 2023 09:42:31 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paZGb-0006La-3D; Fri, 10 Mar 2023 10:42:25 +0100 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1paZGa-00393u-FO; Fri, 10 Mar 2023 10:42:24 +0100 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1paZGZ-00B49b-HT; Fri, 10 Mar 2023 10:42:23 +0100 From: Sascha Hauer To: Barebox List Date: Fri, 10 Mar 2023 10:42:20 +0100 Message-Id: <20230310094222.2538259-6-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230310094222.2538259-1-s.hauer@pengutronix.de> References: <20230310094222.2538259-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230310_014227_786334_E7A19234 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v3 5/7] spi: reduce scope of 'chip' X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) Reducde scope of struct spi_board_info chip to the loop where it is actually only used. While at it drop the memset and let the compiler do the work of initialising it. Signed-off-by: Sascha Hauer --- drivers/spi/spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 1444fe3741..3684647f6e 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -108,7 +108,6 @@ EXPORT_SYMBOL(spi_new_device); static void spi_of_register_slaves(struct spi_controller *ctrl) { struct device_node *n; - struct spi_board_info chip; struct property *reg; struct device_node *node = ctrl->dev->of_node; @@ -119,7 +118,8 @@ static void spi_of_register_slaves(struct spi_controller *ctrl) return; for_each_available_child_of_node(node, n) { - memset(&chip, 0, sizeof(chip)); + struct spi_board_info chip = {}; + chip.name = xstrdup(n->name); chip.bus_num = ctrl->bus_num; /* Mode (clock phase/polarity/etc.) */ -- 2.30.2