[PATCH] Let NET_USB select PHYLIB

[PATCH] Let NET_USB select PHYLIB

[Uwe Kleine-König]

drivers/net/usb/usbnet.c which is compiled with NET_USB=y uses
phy_device_connect() which is only available with PHYLIB=y. So select
PHYLIB from NET_USB and in turn remove the same select from some options
that depend on PHYLIB.

Fixes: 2263e27814f1 ("net: introduce phylib")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/net/usb/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 870f24ca9661..6dc6a24aee93 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -1,12 +1,12 @@
 # SPDX-License-Identifier: GPL-2.0-only
 menuconfig NET_USB
 	depends on USB_HOST
+	select PHYLIB
 	bool "USB network support"
 
 if NET_USB
 
 config NET_USB_ASIX
-	select PHYLIB
 	bool "Asix compatible"
 
 config USB_NET_AX88179_178A
@@ -21,7 +21,6 @@ config USB_NET_AX88179_178A
 	    * Sitcomm LN-032
 
 config NET_USB_SMSC95XX
-	select PHYLIB
 	bool "SMSC95xx"
 
 config NET_USB_RTL8152

base-commit: e3b5c9b60447eb266cb4895ee4662b1b613545b4
-- 
2.39.1

Re: [PATCH] Let NET_USB select PHYLIB

[Sascha Hauer]

On Tue, Mar 14, 2023 at 03:49:09PM +0100, Uwe Kleine-König wrote:
> drivers/net/usb/usbnet.c which is compiled with NET_USB=y uses
> phy_device_connect() which is only available with PHYLIB=y. So select
> PHYLIB from NET_USB and in turn remove the same select from some options
> that depend on PHYLIB.
> 
> Fixes: 2263e27814f1 ("net: introduce phylib")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/net/usb/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 870f24ca9661..6dc6a24aee93 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -1,12 +1,12 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  menuconfig NET_USB
>  	depends on USB_HOST
> +	select PHYLIB
>  	bool "USB network support"
>  
>  if NET_USB
>  
>  config NET_USB_ASIX
> -	select PHYLIB
>  	bool "Asix compatible"
>  
>  config USB_NET_AX88179_178A
> @@ -21,7 +21,6 @@ config USB_NET_AX88179_178A
>  	    * Sitcomm LN-032
>  
>  config NET_USB_SMSC95XX
> -	select PHYLIB
>  	bool "SMSC95xx"
>  
>  config NET_USB_RTL8152
> 
> base-commit: e3b5c9b60447eb266cb4895ee4662b1b613545b4
> -- 
> 2.39.1
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |