From: Sascha Hauer <sha@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] Let NET_USB select PHYLIB
Date: Wed, 15 Mar 2023 09:05:05 +0100 [thread overview]
Message-ID: <20230315080505.GL7446@pengutronix.de> (raw)
In-Reply-To: <20230314144909.2809581-1-u.kleine-koenig@pengutronix.de>
On Tue, Mar 14, 2023 at 03:49:09PM +0100, Uwe Kleine-König wrote:
> drivers/net/usb/usbnet.c which is compiled with NET_USB=y uses
> phy_device_connect() which is only available with PHYLIB=y. So select
> PHYLIB from NET_USB and in turn remove the same select from some options
> that depend on PHYLIB.
>
> Fixes: 2263e27814f1 ("net: introduce phylib")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/net/usb/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 870f24ca9661..6dc6a24aee93 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -1,12 +1,12 @@
> # SPDX-License-Identifier: GPL-2.0-only
> menuconfig NET_USB
> depends on USB_HOST
> + select PHYLIB
> bool "USB network support"
>
> if NET_USB
>
> config NET_USB_ASIX
> - select PHYLIB
> bool "Asix compatible"
>
> config USB_NET_AX88179_178A
> @@ -21,7 +21,6 @@ config USB_NET_AX88179_178A
> * Sitcomm LN-032
>
> config NET_USB_SMSC95XX
> - select PHYLIB
> bool "SMSC95xx"
>
> config NET_USB_RTL8152
>
> base-commit: e3b5c9b60447eb266cb4895ee4662b1b613545b4
> --
> 2.39.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-03-15 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 14:49 Uwe Kleine-König
2023-03-15 8:05 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315080505.GL7446@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox