mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: barebox@lists.infradead.org, Rouven Czerwinski <rouven@czerwinskis.de>
Subject: Re: [PATCH] arm: rockchip: add support for CM3 on IO board
Date: Mon, 20 Mar 2023 09:19:50 +0100	[thread overview]
Message-ID: <20230320081950.sjxg2st6qgqh6l4o@pengutronix.de> (raw)
In-Reply-To: <20230318160635.216749-1-r.czerwinski@pengutronix.de>

Hi Rouven,

On 23-03-18, Rouven Czerwinski wrote:
> From: Rouven Czerwinski <rouven@czerwinskis.de>
> 
> Working:
> - RKBIN DDR training (rk3566_ddr_1056MHz_v1.13.bin)
> - RKBIN TF-A (v1.34) from RKBIN

Can please add the board to Documentation/boards/rockchip.rst?

> - Environment storage
> - DHCP, ping and link detection
> 
> Signed-off-by: Rouven Czerwinski <rouven@czerwinskis.de>
> ---
>  arch/arm/boards/Makefile             |  1 +
>  arch/arm/boards/radxa-cm3/.gitignore |  1 +
>  arch/arm/boards/radxa-cm3/Makefile   |  3 ++
>  arch/arm/boards/radxa-cm3/board.c    | 56 ++++++++++++++++++++++++++++
>  arch/arm/boards/radxa-cm3/lowlevel.c | 50 +++++++++++++++++++++++++
>  arch/arm/dts/Makefile                |  1 +
>  arch/arm/dts/rk3566-cm3-io.dts       | 55 +++++++++++++++++++++++++++
>  arch/arm/mach-rockchip/Kconfig       |  6 +++
>  images/Makefile.rockchip             |  7 ++++
>  9 files changed, 180 insertions(+)
>  create mode 100644 arch/arm/boards/radxa-cm3/.gitignore
>  create mode 100644 arch/arm/boards/radxa-cm3/Makefile
>  create mode 100644 arch/arm/boards/radxa-cm3/board.c
>  create mode 100644 arch/arm/boards/radxa-cm3/lowlevel.c
>  create mode 100644 arch/arm/dts/rk3566-cm3-io.dts

...

> diff --git a/arch/arm/dts/rk3566-cm3-io.dts b/arch/arm/dts/rk3566-cm3-io.dts
> new file mode 100644
> index 0000000000..81f896b943
> --- /dev/null
> +++ b/arch/arm/dts/rk3566-cm3-io.dts
> @@ -0,0 +1,55 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include <arm64/rockchip/rk3566-radxa-cm3-io.dts>
> +#include "rk356x.dtsi"
> +
> +/ {
> +	chosen: chosen {
> +		environment-sd {
> +			compatible = "barebox,environment";
> +			device-path = &environment_sd;
> +			status = "disabled";
> +		};
> +
> +		environment-emmc {
> +			compatible = "barebox,environment";
> +			device-path = &environment_emmc;
> +			status = "disabled";
> +		};
> +	};
> +
> +	memory@a00000 {
> +		device_type = "memory";
> +		reg = <0x0 0x00a00000 0x0 0x7f600000>;
> +	};

Do we need the memoty node here? I recently encountered issues with it
on a i.MX8MP.

Regards,
  Marco



      reply	other threads:[~2023-03-20  8:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-18 16:06 Rouven Czerwinski
2023-03-20  8:19 ` Marco Felsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230320081950.sjxg2st6qgqh6l4o@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=r.czerwinski@pengutronix.de \
    --cc=rouven@czerwinskis.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox