From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 24 Mar 2023 09:31:55 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pfcq2-00D1hc-UM for lore@lore.pengutronix.de; Fri, 24 Mar 2023 09:31:55 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfcq2-0002dB-KM for lore@pengutronix.de; Fri, 24 Mar 2023 09:31:55 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Srkl9cYbD/OiG4nWPK6lLmqU6Ow9H1c0es2ibkEYQE0=; b=GfHXZTsyOWPAd/WqCQkvAn7e0n t2iefJJxLqd9aDbHdEp80ZWeX9aP9rv4EaYBALmTZ//D3cDGV2TA60mhntrrQIBG8v0vTreK+OGnN g7yNGYvsw/BgQ3OSJduyEHihCrVG99BzwFdAZ2uLGGrXaodLRA0upsPrztBLJGnZvpxUosklhigpW +ctWnZ+Zz6HnLcMkj8hNyv4zx0gj0yQEd+6YwCufGdc7UOwupIuGq8NvxMjMsTVWKzIg2/iPjuYyN JCIxvtlqn/lI6nrJZYfQlkuo/C+kk2u914bGFeMpczK2YkNc7Ibq3RtXIDkWSrMEottKUJDRXU9QV pMaJXAPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfcp5-003sek-1N; Fri, 24 Mar 2023 08:30:55 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfcp2-003seC-0N for barebox@lists.infradead.org; Fri, 24 Mar 2023 08:30:53 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfcp0-0002Sy-N8; Fri, 24 Mar 2023 09:30:50 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pfcp0-00048b-Fw; Fri, 24 Mar 2023 09:30:50 +0100 Date: Fri, 24 Mar 2023 09:30:50 +0100 To: Marco Felsch Cc: barebox@lists.infradead.org Message-ID: <20230324083050.GA19113@pengutronix.de> References: <20230323173016.4089191-1-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230323173016.4089191-1-m.felsch@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_013052_150726_EF3C841A X-CRM114-Status: GOOD ( 16.87 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] usb: dwc3: gadget: lower informal user notifaction dequeue operation X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Thu, Mar 23, 2023 at 06:30:16PM +0100, Marco Felsch wrote: > I encounted the below error message on the i.MX8MP if a fastboot gadget > was up and running and barebox does a reset() or boots the kernel: > > ERROR: dwc3 38100000.usb@38100000.of: request 00000000bfd91568 was not queued to ep1out > > Printing an error message during usb_ep_dequeue() is more confusing than > helpful since the usb_ep_dequeue() could be called during unbind() like > it is done for fastboot. Lower the dev_err() message to dev_dbg() to > keep the message for developers. I saw this message as well, but I deliberately kept it in. Motivated by this patch I had a look after it. The correct solution is to not dequeue requests in fastboot_unbind(). fastboot_disable() will already be called which calls usb_ep_disable() which will dequeue all outstanding requests. See the patch I just sent. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |