From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 1/2] mci: rockchip-dwcmshc-sdhci: use sdhci_reset()
Date: Tue, 28 Mar 2023 12:10:36 +0200 [thread overview]
Message-ID: <20230328101037.4101089-1-s.hauer@pengutronix.de> (raw)
We have sdhci_reset() which does the same as the driver specific
variant. Use the common function instead.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mci/rockchip-dwcmshc-sdhci.c | 20 +++-----------------
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git a/drivers/mci/rockchip-dwcmshc-sdhci.c b/drivers/mci/rockchip-dwcmshc-sdhci.c
index a98600cc4c..e1eb4fc788 100644
--- a/drivers/mci/rockchip-dwcmshc-sdhci.c
+++ b/drivers/mci/rockchip-dwcmshc-sdhci.c
@@ -87,26 +87,12 @@ static int rk_sdhci_card_present(struct mci_host *mci)
return !!(sdhci_read32(&host->sdhci, SDHCI_PRESENT_STATE) & SDHCI_CARD_DETECT);
}
-static int rk_sdhci_reset(struct rk_sdhci_host *host, u8 mask)
-{
- sdhci_write8(&host->sdhci, SDHCI_SOFTWARE_RESET, mask);
-
- /* wait for reset completion */
- if (wait_on_timeout(100 * MSECOND,
- !(sdhci_read8(&host->sdhci, SDHCI_SOFTWARE_RESET) & mask))){
- dev_err(host->mci.hw_dev, "SDHCI reset timeout\n");
- return -ETIMEDOUT;
- }
-
- return 0;
-}
-
static int rk_sdhci_init(struct mci_host *mci, struct device *dev)
{
struct rk_sdhci_host *host = to_rk_sdhci_host(mci);
int ret;
- ret = rk_sdhci_reset(host, SDHCI_RESET_ALL);
+ ret = sdhci_reset(&host->sdhci, SDHCI_RESET_ALL);
if (ret)
return ret;
@@ -274,8 +260,8 @@ static int rk_sdhci_send_cmd(struct mci_host *mci, struct mci_cmd *cmd,
error:
if (ret) {
print_error(host, cmd->cmdidx);
- rk_sdhci_reset(host, BIT(1)); /* SDHCI_RESET_CMD */
- rk_sdhci_reset(host, BIT(2)); /* SDHCI_RESET_DATA */
+ sdhci_reset(&host->sdhci, SDHCI_RESET_CMD);
+ sdhci_reset(&host->sdhci, SDHCI_RESET_DATA);
}
sdhci_write32(&host->sdhci, SDHCI_INT_STATUS, ~0);
--
2.39.2
next reply other threads:[~2023-03-28 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 10:10 Sascha Hauer [this message]
2023-03-28 10:10 ` [PATCH 2/2] mci: arasan: " Sascha Hauer
2023-03-28 12:32 ` [PATCH 1/2] mci: rockchip-dwcmshc-sdhci: " Rouven Czerwinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328101037.4101089-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox