mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] ARM: dts: i.MX8MP: snps,dis-u2-freeclk-exists-quirk
@ 2023-03-30 11:38 Ahmad Fatoum
  2023-03-31  5:48 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2023-03-30 11:38 UTC (permalink / raw)
  To: barebox; +Cc: Hans Christian Lonstad, Ahmad Fatoum

Linux v6.1 adds a snps,gfladj-refclk-lpm-sel-quirk property to the
i.MX8MP DWC3 device tree nodes, which is a superset of the existing
snps,dis-u2-freeclk-exists-quirk property. For this reason, the old
property was dropped breaking some usages of barebox i.MX8MP DWC3.

The proper fix would be supporting this new property, which is already
in next as part of the DWC3 driver sync with the kernel.

Until that lands in master though, let's add back the removed property
to fix the regression. Expectation is that we can revert this commit
as part of v2023.05.0.

Link: https://github.com/saschahauer/barebox/issues/19
Reported-by: Hans Christian Lonstad <hcl@datarespons.com>
Fixes: 32e2176ba050 ("dts: update to v6.1-rc1")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/arm/dts/imx8mp.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/dts/imx8mp.dtsi b/arch/arm/dts/imx8mp.dtsi
index 6962d11e853a..3bec8432627f 100644
--- a/arch/arm/dts/imx8mp.dtsi
+++ b/arch/arm/dts/imx8mp.dtsi
@@ -10,6 +10,15 @@
 	};
 };
 
+/* Temporary workaround until snps,gfladj-refclk-lpm-sel-quirk is supported */
+&usb_dwc3_0 {
+	snps,dis-u2-freeclk-exists-quirk;
+};
+
+&usb_dwc3_1 {
+	snps,dis-u2-freeclk-exists-quirk;
+};
+
 /*
  * The DSP reserved memory will collide with the Barebox malloc area for some
  * DRAM sizes, even though the DSP itself is disabled in most configurations.
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] ARM: dts: i.MX8MP: snps,dis-u2-freeclk-exists-quirk
  2023-03-30 11:38 [PATCH master] ARM: dts: i.MX8MP: snps,dis-u2-freeclk-exists-quirk Ahmad Fatoum
@ 2023-03-31  5:48 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2023-03-31  5:48 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox, Hans Christian Lonstad

On Thu, Mar 30, 2023 at 01:38:44PM +0200, Ahmad Fatoum wrote:
> Linux v6.1 adds a snps,gfladj-refclk-lpm-sel-quirk property to the
> i.MX8MP DWC3 device tree nodes, which is a superset of the existing
> snps,dis-u2-freeclk-exists-quirk property. For this reason, the old
> property was dropped breaking some usages of barebox i.MX8MP DWC3.
> 
> The proper fix would be supporting this new property, which is already
> in next as part of the DWC3 driver sync with the kernel.
> 
> Until that lands in master though, let's add back the removed property
> to fix the regression. Expectation is that we can revert this commit
> as part of v2023.05.0.
> 
> Link: https://github.com/saschahauer/barebox/issues/19
> Reported-by: Hans Christian Lonstad <hcl@datarespons.com>
> Fixes: 32e2176ba050 ("dts: update to v6.1-rc1")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  arch/arm/dts/imx8mp.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/dts/imx8mp.dtsi b/arch/arm/dts/imx8mp.dtsi
> index 6962d11e853a..3bec8432627f 100644
> --- a/arch/arm/dts/imx8mp.dtsi
> +++ b/arch/arm/dts/imx8mp.dtsi
> @@ -10,6 +10,15 @@
>  	};
>  };
>  
> +/* Temporary workaround until snps,gfladj-refclk-lpm-sel-quirk is supported */
> +&usb_dwc3_0 {
> +	snps,dis-u2-freeclk-exists-quirk;
> +};
> +
> +&usb_dwc3_1 {
> +	snps,dis-u2-freeclk-exists-quirk;
> +};
> +
>  /*
>   * The DSP reserved memory will collide with the Barebox malloc area for some
>   * DRAM sizes, even though the DSP itself is disabled in most configurations.
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-31  5:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-30 11:38 [PATCH master] ARM: dts: i.MX8MP: snps,dis-u2-freeclk-exists-quirk Ahmad Fatoum
2023-03-31  5:48 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox