mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] pinctrl: stm32: Remove check for pins-are-numbered
@ 2023-03-31 10:31 Ahmad Fatoum
  2023-04-03  7:04 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2023-03-31 10:31 UTC (permalink / raw)
  To: barebox; +Cc: David Jander, Ahmad Fatoum

Upstream has dropped this property from the device trees that we import,
so drop our check for it to fix boot up on STM32MP1.

Link: https://lore.kernel.org/all/20221129023401.278780-3-bero@baylibre.com/
Fixes: 03b1dd74aa6e ("dts: update to v6.3-rc1")
Reported-by: David Jander <david@protonic.nl>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/pinctrl/pinctrl-stm32.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-stm32.c b/drivers/pinctrl/pinctrl-stm32.c
index 15d845e0ad34..1eed5473f6e0 100644
--- a/drivers/pinctrl/pinctrl-stm32.c
+++ b/drivers/pinctrl/pinctrl-stm32.c
@@ -348,11 +348,6 @@ static int stm32_pinctrl_probe(struct device *dev)
 	struct device_node *np = dev->of_node, *child;
 	int ret;
 
-	if (!of_find_property(np, "pins-are-numbered", NULL)) {
-		dev_err(dev, "only pins-are-numbered format supported\n");
-		return -EINVAL;
-	}
-
 	for_each_available_child_of_node(np, child)
 		if (of_property_read_bool(child, "gpio-controller"))
 			nbanks++;
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] pinctrl: stm32: Remove check for pins-are-numbered
  2023-03-31 10:31 [PATCH master] pinctrl: stm32: Remove check for pins-are-numbered Ahmad Fatoum
@ 2023-04-03  7:04 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2023-04-03  7:04 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox, David Jander

On Fri, Mar 31, 2023 at 12:31:23PM +0200, Ahmad Fatoum wrote:
> Upstream has dropped this property from the device trees that we import,
> so drop our check for it to fix boot up on STM32MP1.
> 
> Link: https://lore.kernel.org/all/20221129023401.278780-3-bero@baylibre.com/
> Fixes: 03b1dd74aa6e ("dts: update to v6.3-rc1")
> Reported-by: David Jander <david@protonic.nl>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/pinctrl/pinctrl-stm32.c | 5 -----
>  1 file changed, 5 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/pinctrl/pinctrl-stm32.c b/drivers/pinctrl/pinctrl-stm32.c
> index 15d845e0ad34..1eed5473f6e0 100644
> --- a/drivers/pinctrl/pinctrl-stm32.c
> +++ b/drivers/pinctrl/pinctrl-stm32.c
> @@ -348,11 +348,6 @@ static int stm32_pinctrl_probe(struct device *dev)
>  	struct device_node *np = dev->of_node, *child;
>  	int ret;
>  
> -	if (!of_find_property(np, "pins-are-numbered", NULL)) {
> -		dev_err(dev, "only pins-are-numbered format supported\n");
> -		return -EINVAL;
> -	}
> -
>  	for_each_available_child_of_node(np, child)
>  		if (of_property_read_bool(child, "gpio-controller"))
>  			nbanks++;
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-03  7:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-31 10:31 [PATCH master] pinctrl: stm32: Remove check for pins-are-numbered Ahmad Fatoum
2023-04-03  7:04 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox