From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 11 Apr 2023 14:04:11 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pmCjL-00HWH8-2D for lore@lore.pengutronix.de; Tue, 11 Apr 2023 14:04:11 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmCjK-0004KP-Ua for lore@pengutronix.de; Tue, 11 Apr 2023 14:04:11 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XxO37wM7uVwQyqWX49dzbGF74OxSdQw2kPEpnbkvgio=; b=Khw+n1KCdu2cOvTaC5ILp9x3ve smyDzZfW5+fHAuOKVNExi6I/AICiStJREm7zzYc4IoKpayFVh4LFz+vXxpGJg15vpLrF5WFdDYdqO iv0YYldeMql5UznWu1lGf/rdNFk/oMKhVY0fzFcS4Dq4D/154Bjzv9HBWQTsC9BxLGGvAVZEcMbxg NcL9Oka3iZ6GWJjbB09V51bo9+5iVNPbkkPj/05tYKqJOoWYYPOQQw+x9YUx9ZdSzhXLiVqCfF14E kt5CDDtu/BG00s5oPKdwY086/QFgJSMSfjcuonAuQBEROYt3HD+eKMjcn75d2p5tfmVMDyizHQKJF /3nxIwhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmCiE-00HUzJ-0a; Tue, 11 Apr 2023 12:03:02 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmCiA-00HUyM-2i for barebox@lists.infradead.org; Tue, 11 Apr 2023 12:03:00 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmCi8-0003xK-47; Tue, 11 Apr 2023 14:02:56 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pmCi7-00075w-St; Tue, 11 Apr 2023 14:02:55 +0200 Date: Tue, 11 Apr 2023 14:02:55 +0200 To: Philipp Zabel Cc: barebox@lists.infradead.org Message-ID: <20230411120255.GI19113@pengutronix.de> References: <20230405122734.2348025-1-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230405122734.2348025-1-p.zabel@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_050258_876493_1138A133 X-CRM114-Status: GOOD ( 22.83 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 1/3] video: fb: add optional damage tracking X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Wed, Apr 05, 2023 at 02:27:32PM +0200, Philipp Zabel wrote: > Add an optional fb_damage operation that drivers may use to accumulate > damage on the framebuffer until fb_flush is called. The accumulated > damage can be used to support partial updates for displays with an > integrated framebuffer. > > Signed-off-by: Philipp Zabel > --- > v2: make rect parameter to fb_damage const > --- > drivers/video/fb.c | 6 ++++++ > include/fb.h | 9 +++++++++ > 2 files changed, 15 insertions(+) Applied, thanks Sascha > > diff --git a/drivers/video/fb.c b/drivers/video/fb.c > index 44754065e7d9..6f412d62c434 100644 > --- a/drivers/video/fb.c > +++ b/drivers/video/fb.c > @@ -43,6 +43,12 @@ static int fb_close(struct cdev *cdev) > return 0; > } > > +void fb_damage(struct fb_info *info, struct fb_rect *rect) > +{ > + if (info->fbops->fb_damage) > + info->fbops->fb_damage(info, rect); > +} > + > static int fb_op_flush(struct cdev *cdev) > { > struct fb_info *info = cdev->priv; > diff --git a/include/fb.h b/include/fb.h > index 15bb74b99576..88e6c0e45835 100644 > --- a/include/fb.h > +++ b/include/fb.h > @@ -80,6 +80,13 @@ struct fb_bitfield { > > struct fb_info; > > +struct fb_rect { > + u32 x1; > + u32 y1; > + u32 x2; > + u32 y2; > +}; > + > struct fb_ops { > /* set color register */ > int (*fb_setcolreg)(unsigned regno, unsigned red, unsigned green, > @@ -87,6 +94,7 @@ struct fb_ops { > void (*fb_enable)(struct fb_info *info); > void (*fb_disable)(struct fb_info *info); > int (*fb_activate_var)(struct fb_info *info); > + void (*fb_damage)(struct fb_info *info, const struct fb_rect *rect); > void (*fb_flush)(struct fb_info *info); > }; > > @@ -156,6 +164,7 @@ int register_framebuffer(struct fb_info *info); > > int fb_enable(struct fb_info *info); > int fb_disable(struct fb_info *info); > +void fb_damage(struct fb_info *info, struct fb_rect *rect); > void fb_flush(struct fb_info *info); > > #define FBIOGET_SCREENINFO _IOR('F', 1, loff_t) > -- > 2.39.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |