From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 01 Jun 2023 10:34:48 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q4dlh-005XrE-Ff for lore@lore.pengutronix.de; Thu, 01 Jun 2023 10:34:48 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4dle-0004TX-OX for lore@pengutronix.de; Thu, 01 Jun 2023 10:34:47 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4pJgs1jyXImVqcUrlGVsUqtbl8rxs2z/VkVXfR0oRdw=; b=dKWKkq4vT1/3Y+5uctrh5UFDEh BqPXIvi71b+MPFzmwe9HMOeYjLendudJFfwbyjQK2qBhSI9/nyjcXK/9Y8CRsOijcGPzKt/p7bt3Z 3L8iKwlgAJEszHDy9quji7wYQshFsFbRoQohNUcjPxk94gNdOjNI+jBy6XercObfLtRjn+KdXr291 dQZNGN/atmDJqbgsBvIjQiHWBa1oixz+JcTK73dDX0jTaROIpeuFejNp2CAR9kSWtv5jM57S+Cyoq k1YLzmmXtHw0pQ8GO0E7bHyh+P4ttURmlCRIcbJSDUkmI9e8HHrCa9bREPvDm/puJja8KcLkThlzp MMJGuPDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4dkX-002ZqP-0V; Thu, 01 Jun 2023 08:33:37 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4dkU-002Zpi-2D for barebox@lists.infradead.org; Thu, 01 Jun 2023 08:33:36 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4dkT-0004K9-FN; Thu, 01 Jun 2023 10:33:33 +0200 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1q4dkT-0005Bi-7U; Thu, 01 Jun 2023 10:33:33 +0200 Date: Thu, 1 Jun 2023 10:33:33 +0200 From: Marco Felsch To: Sascha Hauer Cc: Ahmad Fatoum , barebox@lists.infradead.org Message-ID: <20230601083333.nkjmb7ggcttchet2@pengutronix.de> References: <20230531145927.1399282-1-a.fatoum@pengutronix.de> <20230531145927.1399282-12-a.fatoum@pengutronix.de> <20230601074204.GI18491@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230601074204.GI18491@pengutronix.de> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_013334_725899_C6B3F2FD X-CRM114-Status: GOOD ( 27.16 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 11/18] block: parse partition table on block device registration X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 23-06-01, Sascha Hauer wrote: > On Wed, May 31, 2023 at 04:59:20PM +0200, Ahmad Fatoum wrote: > > Every instance where we register a block device, it's followed by an > > attempt to parse the partition table, most often with a warning when > > it fails. Thus let's move partition table parsing into > > blockdevice_register. > > > > Signed-off-by: Ahmad Fatoum > > --- > > arch/sandbox/board/hostfile.c | 4 ---- > > common/block.c | 6 ++++++ > > drivers/ata/disk_ata_drive.c | 5 ----- > > drivers/block/efi-block-io.c | 9 +-------- > > drivers/block/virtio_blk.c | 8 +------- > > drivers/mci/mci-core.c | 6 ------ > > drivers/nvme/host/core.c | 5 ----- > > drivers/usb/storage/usb.c | 5 ----- > > 8 files changed, 8 insertions(+), 40 deletions(-) > > > > diff --git a/arch/sandbox/board/hostfile.c b/arch/sandbox/board/hostfile.c > > index d0f400787d7a..a1ab06b87770 100644 > > --- a/arch/sandbox/board/hostfile.c > > +++ b/arch/sandbox/board/hostfile.c > > @@ -166,10 +166,6 @@ static int hf_probe(struct device *dev) > > if (err) > > return err; > > > > - err = parse_partition_table(&priv->blk); > > - if (err) > > - dev_warn(dev, "No partition table found\n"); > > - > > dev_info(dev, "registered as block device\n"); > > } else { > > cdev->name = np->name; > > diff --git a/common/block.c b/common/block.c > > index c39269d3a692..98adcfdf3dab 100644 > > --- a/common/block.c > > +++ b/common/block.c > > @@ -6,6 +6,7 @@ > > */ > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -408,6 +409,11 @@ int blockdevice_register(struct block_device *blk) > > > > cdev_create_default_automount(&blk->cdev); > > > > + /* Lack of partition table is unusual, but not a failure */ > > + ret = parse_partition_table(blk); > > + if (ret) > > + dev_warn(blk->dev, "No partition table found\n"); > > This is not changed in this series, so it's ok like this, but should > this really be a warning? Using a raw device without a partition table > seems like a legitimate usecase. Good point, maybe we should use dev_notice() as compromise? Regards, Marco > Sascha > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > >