From: Marco Felsch <m.felsch@pengutronix.de>
To: Jules Maselbas <jmaselbas@zdiv.net>
Cc: barebox@lists.infradead.org, Jules Maselbas <jmaselbas@kalray.eu>
Subject: Re: [PATCH 10/10] gpiolib: add of_xlate support
Date: Mon, 5 Jun 2023 11:51:12 +0200 [thread overview]
Message-ID: <20230605095112.klegu75j75k52q6g@pengutronix.de> (raw)
In-Reply-To: <ZH2TgqgGagHTCfEQ@tour>
Hi Jules,
On 23-06-05, Jules Maselbas wrote:
> Hi Marco,
>
> I tried this patch series on my sunxi branch and it applies nicely
> but failed to get the gpio with the following message:
> of_get_named_gpio_flags: unable to get gpio num of device 1c20800.pinctrl@1c20800.of: -22
>
> The error -22 is for -EINVAL which comes form of_xlate_and_get_gpiod_flags
> because the test `chip->of_gpio_n_cells != gpiospec->args_count` fails,
> `of_gpio_n_cells` hasn't been set by the driver and it value was 0.
>
> I wonder if `of_gpio_n_cells` should be set by the driver or by parsing the
> #gpio-cells property from device-tree?
The driver need to define the cells since the driver is the one
interpreting the cells, please have a look on:
https://elixir.bootlin.com/linux/v6.4-rc1/source/drivers/pinctrl/sunxi/pinctrl-sunxi.c#L1583
> By setting the expected value in the driver resolves this "issue".
Cool :) so you are able to controll the sunxi-gpios? :)
Thanks a lot for testing. I will send a v2 with your found spelling
issues.
Regards,
Marco
> Cheers,
> -- Jules
>
> > diff --git a/drivers/of/of_gpio.c b/drivers/of/of_gpio.c
> > +static int of_xlate_and_get_gpiod_flags(struct gpio_chip *chip,
> > + struct of_phandle_args *gpiospec,
> > + enum of_gpio_flags *flags)
> > +{
> > + if (chip->of_gpio_n_cells != gpiospec->args_count)
> > + return -EINVAL;
> error message caused by this ^
>
> > +
> > + return chip->ops->of_xlate(chip, gpiospec, flags);
> > +}
> > +
> > /**
> > * of_get_named_gpio_flags() - Get a GPIO number and flags to use with GPIO API
> > * @np: device node to get GPIO from
> > @@ -61,7 +99,7 @@ int of_get_named_gpio_flags(struct device_node *np, const char *propname,
> > int index, enum of_gpio_flags *flags)
> > {
> > struct of_phandle_args gpiospec;
> > - struct device *dev;
> > + struct gpio_chip *chip;
> > int ret;
> >
> > ret = of_parse_phandle_with_args(np, propname, "#gpio-cells",
> > @@ -72,27 +110,21 @@ int of_get_named_gpio_flags(struct device_node *np, const char *propname,
> > return ret;
> > }
> >
> > - dev = of_find_device_by_node(gpiospec.np);
> > - if (!dev) {
> > - pr_debug("%s: unable to find device of node %s\n",
> > - __func__, gpiospec.np->full_name);
> > + chip = of_find_gpiochip_by_xlate(&gpiospec);
> > + if (!chip) {
> > ret = -EPROBE_DEFER;
> > goto out;
> > }
> >
> > - ret = gpio_get_num(dev, gpiospec.args[0]);
> > - if (ret == -EPROBE_DEFER)
> > - goto out;
> > + ret = of_xlate_and_get_gpiod_flags(chip, &gpiospec, flags);
> > if (ret < 0) {
> > pr_err("%s: unable to get gpio num of device %s: %d\n",
> got this error message here
>
> > - __func__, dev_name(dev), ret);
> > + __func__, dev_name(chip->dev), ret);
> > goto out;
> > }
> >
> > - if (flags) {
> > - *flags = gpiospec.args[1];
> > + if (flags)
> > of_gpio_flags_quirks(np, propname, flags, index);
> > - }
> >
> > out:
> > of_node_put(gpiospec.np);
>
next prev parent reply other threads:[~2023-06-05 9:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 7:49 [PATCH 00/10] Fix gpio-hogs and sync with Linux gpiolib Marco Felsch
2023-06-02 7:49 ` [PATCH 01/10] gpiolib: fix gpio-hog functionality Marco Felsch
2023-06-13 7:36 ` Ahmad Fatoum
2023-06-02 7:49 ` [PATCH 02/10] gpiolib: simplify for loop break condition Marco Felsch
2023-06-13 7:37 ` Ahmad Fatoum
2023-06-02 7:49 ` [PATCH 03/10] gpiolib: rename local gpio-line-names variable Marco Felsch
2023-06-13 7:38 ` Ahmad Fatoum
2023-06-02 7:49 ` [PATCH 04/10] gpiolib: fix gpio name memory leak Marco Felsch
2023-06-13 7:39 ` Ahmad Fatoum
2023-06-02 7:49 ` [PATCH 05/10] gpiolib: fix missing error check while query gpio-line-names Marco Felsch
2023-06-13 7:43 ` Ahmad Fatoum
2023-06-02 7:49 ` [PATCH 06/10] gpiolib: refactor gpio-line-names parsing Marco Felsch
2023-06-13 7:44 ` Ahmad Fatoum
2023-06-02 7:49 ` [PATCH 07/10] gpiolib: introduce of_gpiochip_add to bundle all of functions Marco Felsch
2023-06-13 7:46 ` Ahmad Fatoum
2023-06-02 7:49 ` [PATCH 08/10] OF: gpio: snyc of_get_named_gpio_flags variable with kernel Marco Felsch
2023-06-02 8:04 ` Jules Maselbas
2023-06-13 7:46 ` Ahmad Fatoum
2023-06-02 7:49 ` [PATCH 09/10] OF: gpio: fix device_node leakage Marco Felsch
2023-06-13 7:49 ` Ahmad Fatoum
2023-06-13 8:22 ` Marco Felsch
2023-06-02 7:49 ` [PATCH 10/10] gpiolib: add of_xlate support Marco Felsch
2023-06-02 8:11 ` Jules Maselbas
2023-06-05 7:49 ` Jules Maselbas
2023-06-05 9:51 ` Marco Felsch [this message]
2023-06-13 7:58 ` Ahmad Fatoum
2023-06-13 13:05 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605095112.klegu75j75k52q6g@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jmaselbas@kalray.eu \
--cc=jmaselbas@zdiv.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox