From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 09 Jun 2023 08:18:41 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q7VSN-00GpMQ-8t for lore@lore.pengutronix.de; Fri, 09 Jun 2023 08:18:41 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7VSK-0008Qi-Fh for lore@pengutronix.de; Fri, 09 Jun 2023 08:18:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tV2901BqpUDkmafEH9G16unQDhdMMJZUpFjbhuaywHs=; b=CoKbPYqT8TSuK7pTXho/ySAyN5 6smdDQu2RHl8OmLHa7lnh+xwtrB+b1xS3bHL5ccEmBtV4ypA9K/lpGULA40whm4tKWLHou1dOR366 do1t2Pytpxf92oqrreI86OlDg0vQZKYQToH0jPh1CWGZBlZ94eOf7Oxet7A5yHdurQip9IWqo+iNu 3N0Dm9CqSiNJZ31ijMNHGScSWuy2qvOf8EUJFVSaYzDFW3mGja1kyfLcyoV93kzSczjeRueQLr+Hc ZGAgXwFVHSSJrsTNf0ocPaoRP8sDygs231vqP+T64Sycl25Bu3pDW8agqL4zkaLnOzm28DoOSB57w jDWDSavQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7VRL-00Bpnr-1v; Fri, 09 Jun 2023 06:17:39 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7VRI-00Bpmd-13 for barebox@lists.infradead.org; Fri, 09 Jun 2023 06:17:38 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7VRH-0008If-3p; Fri, 09 Jun 2023 08:17:35 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1q7VRG-0007Yw-S6; Fri, 09 Jun 2023 08:17:34 +0200 Date: Fri, 9 Jun 2023 08:17:34 +0200 From: Sascha Hauer To: Yegor Yefremov Cc: barebox@lists.infradead.org Message-ID: <20230609061734.GL18491@pengutronix.de> References: <20230606081718.2246807-1-yegorslists@googlemail.com> <20230606095851.GD18491@pengutronix.de> <20230609061521.GK18491@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230609061521.GK18491@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_231736_362417_DF639B50 X-CRM114-Status: GOOD ( 25.40 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2] net: phy: add driver for MotorComm PHY X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Fri, Jun 09, 2023 at 08:15:21AM +0200, Sascha Hauer wrote: > On Thu, Jun 08, 2023 at 12:48:47PM +0200, Yegor Yefremov wrote: > > Hi Sascha, > > > > On Tue, Jun 6, 2023 at 11:58 AM Sascha Hauer wrote: > > > > > > Hi Yegor, > > > > > > On Tue, Jun 06, 2023 at 10:21:39AM +0200, Yegor Yefremov wrote: > > > > Hi Sascha, > > > > > > > > > > > > > + ret = phy_modify(phydev, YT8511_PAGE, YT8511_DELAY_FE_TX_EN, fe); > > > > > + if (ret < 0) > > > > > + goto err_restore_page; > > > > > + > > > > > + /* leave pll enabled in sleep */ > > > > > + ret = phy_write(phydev, YT8511_PAGE_SELECT, YT8511_EXT_SLEEP_CTRL); > > > > > + if (ret < 0) > > > > > + goto err_restore_page; > > > > > + > > > > > + ret = phy_modify(phydev, YT8511_PAGE, 0, YT8511_PLLON_SLP); > > > > > + if (ret < 0) > > > > > + goto err_restore_page; > > > > > + > > > > > +err_restore_page: > > > > > + return phy_restore_page(phydev, oldpage, ret); > > > > > > > > As for this approach, it is also used by some other drivers in the Linux kernel: > > > > > > > > drivers/net/phy/realtek.c > > > > drivers/net/phy/icplus.c > > > > > > It's ok like this. I didn't realize phy_restore_page() takes ret as > > > argument and returns it. > > > > The driver doesn't use a phy_id_mask for now and it causes problems > > that unknown PHY will be assigned to MotorComm. What mask should I > > use? 0xfffffff or 0x00000fff? > > It is PHY_ID_MATCH_EXACT() in the kernel, so should be 0xffffffff. I fixed up the patch Regards, Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |