Re: [PATCH] ARM: i.MX8M: iomux-mx8mm: add pad ctrl defines

[Sascha Hauer <sha@pengutronix.de>]

On Thu, Jun 22, 2023 at 08:19:07PM +0200, Marco Felsch wrote:
> Add pad ctrl defines like already done for the 8mp.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  include/mach/imx/iomux-mx8mm.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/include/mach/imx/iomux-mx8mm.h b/include/mach/imx/iomux-mx8mm.h
> index f2ebde3d3b..24e7e4afe3 100644
> --- a/include/mach/imx/iomux-mx8mm.h
> +++ b/include/mach/imx/iomux-mx8mm.h
> @@ -691,6 +691,16 @@ enum {
>  	IMX8MM_PAD_UART4_TXD_GPIO5_IO29                               =  IOMUX_PAD(0x04B8, 0x0250, 5, 0x0000, 0, 0),
>  };
>  
> +#define MX8MM_PAD_CTL_DSE1	(0 << 1)
> +#define MX8MM_PAD_CTL_DSE2	(2 << 1)
> +#define MX8MM_PAD_CTL_DSE4	(1 << 1)
> +#define MX8MM_PAD_CTL_DSE6	(3 << 1)
> +#define MX8MM_PAD_CTL_FSEL	BIT(4)
> +#define MX8MM_PAD_CTL_ODE	BIT(5)
> +#define MX8MM_PAD_CTL_PUE	BIT(6)
> +#define MX8MM_PAD_CTL_HYS	BIT(7)
> +#define MX8MM_PAD_CTL_PE	BIT(8)

Can't we just add MX8M_PAD_CTL_* defines? They are likely all the same
for all i.MX8M variants.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |