Re: [PATCH master v1 5/6] ARM64: unset CONFIG_MISSING_FIRMWARE_ERROR for Rockchip/i.MX

[Marco Felsch <m.felsch@pengutronix.de>]

On 23-06-26, Ahmad Fatoum wrote:
> barebox ARMv8 images for Rockchip and i.MX depend on external firmware
> for RAM setup (e.g. DDR PHY firmware) and on a BL31 binary to service
> secure monitor calls of the operating system (usually TF-A).
> 
> Images without this firmware are not functional and the build warns
> about it, yet for development, it's more convenient to have the build
> not fail. This is especially useful for multi_v8_defconfig, which also
> builds the drivers Qemu Virt64 image and which requires no extra
> firmware.

IMHO most user just use the defconfig as base and so they never notice
the new CONFIG_MISSING_FIRMWARE_ERROR switch. Since you have added a
great mechanism to inform the user that a particular barebox-bin is
missing firmware-files I would tend to set this config to 'n'.

Regards,
  Marco

> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  arch/arm/configs/imx_v8_defconfig      | 1 +
>  arch/arm/configs/multi_v8_defconfig    | 1 +
>  arch/arm/configs/rockchip_v8_defconfig | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/arch/arm/configs/imx_v8_defconfig b/arch/arm/configs/imx_v8_defconfig
> index 93b85ff5ea40..99d871bfb968 100644
> --- a/arch/arm/configs/imx_v8_defconfig
> +++ b/arch/arm/configs/imx_v8_defconfig
> @@ -147,3 +147,4 @@ CONFIG_FS_FAT_WRITE=y
>  CONFIG_FS_FAT_LFN=y
>  CONFIG_FS_RATP=y
>  CONFIG_ZLIB=y
> +# CONFIG_MISSING_FIRMWARE_ERROR is not set
> diff --git a/arch/arm/configs/multi_v8_defconfig b/arch/arm/configs/multi_v8_defconfig
> index e0ff21641a01..76b80975887d 100644
> --- a/arch/arm/configs/multi_v8_defconfig
> +++ b/arch/arm/configs/multi_v8_defconfig
> @@ -241,3 +241,4 @@ CONFIG_FS_PSTORE=y
>  CONFIG_FS_PSTORE_CONSOLE=y
>  CONFIG_FS_RATP=y
>  CONFIG_LZO_DECOMPRESS=y
> +# CONFIG_MISSING_FIRMWARE_ERROR is not set
> diff --git a/arch/arm/configs/rockchip_v8_defconfig b/arch/arm/configs/rockchip_v8_defconfig
> index cc3c3c6d489b..7d1d41965ece 100644
> --- a/arch/arm/configs/rockchip_v8_defconfig
> +++ b/arch/arm/configs/rockchip_v8_defconfig
> @@ -149,3 +149,4 @@ CONFIG_FS_FAT_LFN=y
>  CONFIG_FS_BPKFS=y
>  CONFIG_FS_UIMAGEFS=y
>  CONFIG_LZO_DECOMPRESS=y
> +# CONFIG_MISSING_FIRMWARE_ERROR is not set
> -- 
> 2.39.2
> 
> 
>