Re: [PATCH] nios2: remove arch remains from drivers

[Sascha Hauer <sha@pengutronix.de>]

On Fri, Jun 30, 2023 at 09:55:29PM +0300, Denis Orlov wrote:
> On 6/30/23 11:57, Ian Abbott wrote:
> > On 29/06/2023 21:13, Denis Orlov wrote:
> >> The architecture was removed back in the commit efccc13513, however some
> >> drivers that were available exclusively for NIOS2 were left over. As it
> >> has been impossible to compile those since then, it seems reasonable to
> >> just get rid of them.
> >>
> >> Signed-off-by: Denis Orlov <denorl2009@gmail.com>
> >> ---
> >>   drivers/serial/Kconfig              |  10 --
> >>   drivers/serial/Makefile             |   2 -
> >>   drivers/serial/serial_altera.c      |  94 -----------
> >>   drivers/serial/serial_altera_jtag.c |  99 ------------
> >>   drivers/spi/Kconfig                 |   4 -
> >>   drivers/spi/Makefile                |   1 -
> >>   drivers/spi/altera_spi.c            | 236 ----------------------------
> >>   7 files changed, 446 deletions(-)
> >>   delete mode 100644 drivers/serial/serial_altera.c
> >>   delete mode 100644 drivers/serial/serial_altera_jtag.c
> >>   delete mode 100644 drivers/spi/altera_spi.c
> >
> > As a point of interest, none of those drivers should really depend on NIOS2.  They are usable on an ARM SoCFPGA system if the FPGA logic contains the corresponding Altera/Intel IP components.
> >
> > Whether or not anyone needs them in barebox is another matter, but I have certainly used them in ARM SoCFPGA Linux systems booted from barebox.
> >
> 
> Hmm, maybe those drivers should rather depend on ARCH_SOCFPGA then?
> Would be great if someone tested them in barebox running on a SoCFPGA.
> Otherwise, they are just rotting in the source tree, with no actual
> usage.

To make them usable on SoCFPGA the drivers would at least need device
tree probing support. drivers/serial/serial_altera.c needs a CPU_FREQ
define for baudrate setting. This would have to be replaced with clk
support. I think we can remove them from the tree for now and add them
back in a fresh state once somebody needs them.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |