From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org,
"Rouven Czerwinski" <r.czerwinski@pengutronix.de>,
"Michael Olbrich" <mol@pengutronix.de>,
"Enrico Jörns" <e.joerns@pengutronix.de>
Subject: Re: [PATCH master] kbuild: delete images with missing firmware instead of truncating
Date: Mon, 3 Jul 2023 14:48:28 +0200 [thread overview]
Message-ID: <20230703124828.GO18491@pengutronix.de> (raw)
In-Reply-To: <20230703095608.2188064-1-a.fatoum@pengutronix.de>
On Mon, Jul 03, 2023 at 11:56:08AM +0200, Ahmad Fatoum wrote:
> It may be confusing to users to be left with a 0-byte image, so let's
> delete it instead. This means that every build with missing firmware will
> attempt the final make targets, only to delete them at the end.
>
> At the flip-side, there is no risk of broken images to be used later on.
>
> Suggested-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> Suggested-by: Michael Olbrich <mol@pengutronix.de>
> Suggested-by: Enrico Jörns <e.joerns@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> images/Makefile | 4 ++--
> scripts/Makefile.lib | 3 +++
> 2 files changed, 5 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-07-03 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 9:56 Ahmad Fatoum
2023-07-03 12:48 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703124828.GO18491@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=e.joerns@pengutronix.de \
--cc=mol@pengutronix.de \
--cc=r.czerwinski@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox