mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Bastian Krause <bst@pengutronix.de>,
	Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/2] soc: imx: have IMX8M_FEATCTRL select IMX_OCOTP
Date: Mon,  3 Jul 2023 19:20:54 +0200	[thread overview]
Message-ID: <20230703172054.536931-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20230703172054.536931-1-a.fatoum@pengutronix.de>

IMX8M_FEATCTRL selects FEATURE_CONTROLLER, so of_feature_controller_check()
will return an error if the feature controller driver is missing.

Given that the default for IMX_OCOTP is n, but for IMX8M_FEATCTRL is y,
this error case is easily hit. Resolve this by selecting IMX_OCOTP when
IMX8M_FEATCTRL is enabled.

Reported-by: Bastian Krause <bst@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/soc/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index b11db718c2bc..71f72eb4802b 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -11,6 +11,7 @@ config IMX8M_FEATCTRL
 	bool "i.MX8M feature controller"
 	depends on ARCH_IMX8M
 	select FEATURE_CONTROLLER
+	select IMX_OCOTP
 	default y
 	help
 	  This driver disables device tree nodes that are not applicable
-- 
2.39.2




  reply	other threads:[~2023-07-03 17:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 17:20 [PATCH 1/2] soc: imx: featctrl: add help text for CONFIG_IMX8M_FEATCTRL Ahmad Fatoum
2023-07-03 17:20 ` Ahmad Fatoum [this message]
2023-07-04  8:58 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230703172054.536931-2-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=bst@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox