[PATCH 1/2] soc: imx: featctrl: add help text for CONFIG_IMX8M_FEATCTRL

[PATCH 1/2] soc: imx: featctrl: add help text for CONFIG_IMX8M_FEATCTRL

[Ahmad Fatoum]

There's no equivalent Linux driver, so a short help text is certainly in
order. While at it, replace spaces with tabs for the prompt line.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/soc/imx/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 06513c02da2f..b11db718c2bc 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -8,9 +8,12 @@ config IMX_GPCV2_PM_DOMAINS
 	default y if ARCH_IMX7 || ARCH_IMX8M
 
 config IMX8M_FEATCTRL
-        bool "i.MX8M feature controller"
+	bool "i.MX8M feature controller"
 	depends on ARCH_IMX8M
 	select FEATURE_CONTROLLER
 	default y
+	help
+	  This driver disables device tree nodes that are not applicable
+	  to Lite variants of i.MX8M SoCs.
 
 endmenu
-- 
2.39.2

[PATCH 2/2] soc: imx: have IMX8M_FEATCTRL select IMX_OCOTP

[Ahmad Fatoum]

IMX8M_FEATCTRL selects FEATURE_CONTROLLER, so of_feature_controller_check()
will return an error if the feature controller driver is missing.

Given that the default for IMX_OCOTP is n, but for IMX8M_FEATCTRL is y,
this error case is easily hit. Resolve this by selecting IMX_OCOTP when
IMX8M_FEATCTRL is enabled.

Reported-by: Bastian Krause <bst@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/soc/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index b11db718c2bc..71f72eb4802b 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -11,6 +11,7 @@ config IMX8M_FEATCTRL
 	bool "i.MX8M feature controller"
 	depends on ARCH_IMX8M
 	select FEATURE_CONTROLLER
+	select IMX_OCOTP
 	default y
 	help
 	  This driver disables device tree nodes that are not applicable
-- 
2.39.2

Re: [PATCH 1/2] soc: imx: featctrl: add help text for CONFIG_IMX8M_FEATCTRL

[Sascha Hauer]

On Mon, Jul 03, 2023 at 07:20:53PM +0200, Ahmad Fatoum wrote:
> There's no equivalent Linux driver, so a short help text is certainly in
> order. While at it, replace spaces with tabs for the prompt line.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/soc/imx/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
> index 06513c02da2f..b11db718c2bc 100644
> --- a/drivers/soc/imx/Kconfig
> +++ b/drivers/soc/imx/Kconfig
> @@ -8,9 +8,12 @@ config IMX_GPCV2_PM_DOMAINS
>  	default y if ARCH_IMX7 || ARCH_IMX8M
>  
>  config IMX8M_FEATCTRL
> -        bool "i.MX8M feature controller"
> +	bool "i.MX8M feature controller"
>  	depends on ARCH_IMX8M
>  	select FEATURE_CONTROLLER
>  	default y
> +	help
> +	  This driver disables device tree nodes that are not applicable
> +	  to Lite variants of i.MX8M SoCs.
>  
>  endmenu
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |