* [PATCH master] firmware: use portable newline escape
@ 2023-07-03 17:21 Ahmad Fatoum
0 siblings, 0 replies; only message in thread
From: Ahmad Fatoum @ 2023-07-03 17:21 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
We want to print `\n' literally into the *.gen.S file, so gas turns it
into a literal new line character. Depending on shell, the current
scheme might work, but let's play it safe and use single quotes. This
fixes a cosmetic issue of non-escaped `\n' making it into the missing
section on NixOS, which leads to slightly garbled output when firmware
is missing.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
firmware/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/firmware/Makefile b/firmware/Makefile
index 8d3bfb0752ff..5cdff8b85893 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -62,7 +62,7 @@ filechk_fwbin = { \
echo "\#ifdef __PBL__" ;\
echo " .section .missing_fw,\"a\"" ;\
echo "_fwname_$(FWSTR):" ;\
- echo ".ascii \"firmware/$(FWNAME)\\\\n\"" ;\
+ echo '.ascii "firmware/$(FWNAME)\n"' ;\
echo "\#endif" ;\
}
--
2.39.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-07-03 17:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-03 17:21 [PATCH master] firmware: use portable newline escape Ahmad Fatoum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox