mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH v2 2/3] commands: test: replace printf with pr_err
Date: Tue,  4 Jul 2023 13:29:20 +0200	[thread overview]
Message-ID: <20230704112921.741776-2-m.felsch@pengutronix.de> (raw)
In-Reply-To: <20230704112921.741776-1-m.felsch@pengutronix.de>

Replace the printf() with pr_err() to support:
 - color formated prints
 - logbuffer storing (dmesg)
 - loglevels

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
v2:
 - new patch

 commands/test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/commands/test.c b/commands/test.c
index c1b84c42ef..5478011185 100644
--- a/commands/test.c
+++ b/commands/test.c
@@ -77,7 +77,7 @@ static int do_test(int argc, char *argv[])
 	if (*argv[0] == '[') {
 		argc--;
 		if (*argv[argc] != ']') {
-			printf("[: missing `]'\n");
+			pr_err("[: missing `]'\n");
 			return 1;
 		}
 	}
@@ -213,7 +213,7 @@ static int do_test(int argc, char *argv[])
 		}
 
 		if (left < adv) {
-			printf("test: failed to parse arguments\n");
+			pr_err("test: failed to parse arguments\n");
 			return 1;
 		}
 
-- 
2.39.2




  reply	other threads:[~2023-07-04 11:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04 11:29 [PATCH v2 1/3] commands: test: simplify argv handling Marco Felsch
2023-07-04 11:29 ` Marco Felsch [this message]
2023-07-04 11:38   ` [PATCH v2 2/3] commands: test: replace printf with pr_err Sascha Hauer
2023-07-04 11:59     ` Marco Felsch
2023-07-04 11:29 ` [PATCH v2 3/3] commands: test: add based support for bash-test style Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230704112921.741776-2-m.felsch@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox