From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 06 Jul 2023 18:18:22 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qHRgV-000NFF-QK for lore@lore.pengutronix.de; Thu, 06 Jul 2023 18:18:22 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHRgT-0007Jh-EV for lore@pengutronix.de; Thu, 06 Jul 2023 18:18:21 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=J35dDy3O3SVsb976ZnpcG5fr10rNu7IPzpsKreitAWE=; b=CoFGVlLI93RYSGbPGdkKoSlbFT DV3ls2/iBUT8QUG1LOFT49NA58JaM0rRej/U//lg6WsBjGRb8WhmrwuVEd3Z579oH6tyieQP3/LGP VkKnGXc4GxNGN3yXiqVkli2EcSLaLFxicmnVmlIs8ByIqQRLX5WNmoWqEHP7isY46SrGCv/xnIIoA MNRj0u75fPHfJNQaxhkVjIgUFiLc/xr16mmKc9fBSYeskU9dDvJdeloed1LiuwRfVuiXMzfMRqST+ u1gIwXYhi2fpEoo3VHK0KpMey43g7Dpo4+/x/1msPZBelpcVz9CKOd0/UcMUsjuK8KbzrOcQKE9OO 7igvJgYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHRf1-0028mZ-0u; Thu, 06 Jul 2023 16:16:51 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHRey-0028lE-0n for barebox@lists.infradead.org; Thu, 06 Jul 2023 16:16:49 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHRes-0007EY-Im; Thu, 06 Jul 2023 18:16:42 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qHRer-00CXp8-UF; Thu, 06 Jul 2023 18:16:41 +0200 Received: from afa by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1qHRer-003XU3-1b; Thu, 06 Jul 2023 18:16:41 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Thu, 6 Jul 2023 18:16:40 +0200 Message-Id: <20230706161640.843682-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230706_091648_286113_2DABDECA X-CRM114-Status: GOOD ( 10.75 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] ddr: imx8m: add comment and print out prior to first DDRC read X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) If board code low level entry forgets to call imx8m*_early_clock_init before DRAM setup, write access to DRAM controller will seem to work, but the first read access will hang the system. Make debugging this board bring up mistake easier by adding a debug print along with a comment. Signed-off-by: Ahmad Fatoum --- drivers/ddr/imx8m/ddr_init.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/ddr/imx8m/ddr_init.c b/drivers/ddr/imx8m/ddr_init.c index 944cc3873e0c..9a86280d9c73 100644 --- a/drivers/ddr/imx8m/ddr_init.c +++ b/drivers/ddr/imx8m/ddr_init.c @@ -106,7 +106,11 @@ int imx8m_ddr_init(struct dram_timing_info *dram_timing, reg32_write(DDRC_RFSHCTL3(0), 0x0000001); reg32_write(DDRC_PWRCTL(0), 0xa0); - /* if ddr type is LPDDR4, do it */ + pr_debug("checking ddr type\n"); + /* + * below is first read, so if boot hangs here, imx8m*_early_clock_init() + * might not have been called + */ tmp = reg32_read(DDRC_MSTR(0)); if (tmp & (0x1 << 5) && ddrc_type != DDRC_TYPE_MN) reg32_write(DDRC_DDR_SS_GPR0, 0x01); /* LPDDR4 mode */ -- 2.39.2