From: Sam Ravnborg <sam@ravnborg.org>
To: Jules Maselbas <jmaselbas@kalray.eu>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/8] mci: Add dwcmshc-sdhci driver
Date: Mon, 10 Jul 2023 21:47:03 +0200 [thread overview]
Message-ID: <20230710194703.GA19256@ravnborg.org> (raw)
In-Reply-To: <20230710172335.26701-3-jmaselbas@kalray.eu>
Hi Jules.
On Mon, Jul 10, 2023 at 07:23:30PM +0200, Jules Maselbas wrote:
> This driver initially started as a modification of dove-sdhci driver,
> it has been heavily reworked to be closer to rockchip-dwcmshc-sdhci by
> using more common sdhci code.
>
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> ---
> drivers/mci/Kconfig | 8 +
> drivers/mci/Makefile | 1 +
> drivers/mci/dwcmshc-sdhci.c | 520 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 529 insertions(+)
> create mode 100644 drivers/mci/dwcmshc-sdhci.c
Unless there are good reasons that I miss you could squash this with
patch 8. It looks funny that you add a driver and then delete a lot of
code because you updated some infrastructure later.
This is to have a clean git history, which one could always ague about.
Sam
next prev parent reply other threads:[~2023-07-10 19:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 17:23 [PATCH 1/8] mci: sdhci: Set 8-bit host caps Jules Maselbas
2023-07-10 17:23 ` [PATCH 2/8] mci: sdhci: Add registers defines Jules Maselbas
2023-07-10 17:23 ` [PATCH 3/8] mci: Add dwcmshc-sdhci driver Jules Maselbas
2023-07-10 19:47 ` Sam Ravnborg [this message]
2023-07-11 8:12 ` Jules Maselbas
2023-07-26 13:11 ` Sascha Hauer
2023-07-10 17:23 ` [PATCH 4/8] mci: sdhci: Actually return the error code instead of 0 Jules Maselbas
2023-07-10 17:23 ` [PATCH 5/8] mci: sdhci: Add sd host v4 mode Jules Maselbas
2023-07-10 17:23 ` [PATCH 6/8] mci: sdhci: Add 64-bit DMA addressing suport for V4 mode Jules Maselbas
2023-07-10 17:23 ` [PATCH 7/8] mci: sdhci: Force DMA update to the next block boundary Jules Maselbas
2023-07-11 9:46 ` Jules Maselbas
2023-07-11 13:40 ` [PATCH] fixup! " Jules Maselbas
2023-07-10 17:23 ` [PATCH 8/8] mci: dwcmshc: Use sdhci_enable_v4_mode() Jules Maselbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710194703.GA19256@ravnborg.org \
--to=sam@ravnborg.org \
--cc=barebox@lists.infradead.org \
--cc=jmaselbas@kalray.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox