From: Sascha Hauer <sha@pengutronix.de>
To: Jules Maselbas <jmaselbas@kalray.eu>
Cc: Sam Ravnborg <sam@ravnborg.org>, barebox@lists.infradead.org
Subject: Re: [PATCH 3/8] mci: Add dwcmshc-sdhci driver
Date: Wed, 26 Jul 2023 15:11:05 +0200 [thread overview]
Message-ID: <20230726131105.GS18491@pengutronix.de> (raw)
In-Reply-To: <ZK0O9ya3gVS8DAam@tellis.lin.mbt.kalray.eu>
On Tue, Jul 11, 2023 at 10:12:39AM +0200, Jules Maselbas wrote:
> Hi Sam,
>
> On Mon, Jul 10, 2023 at 09:47:03PM +0200, Sam Ravnborg wrote:
> > Unless there are good reasons that I miss you could squash this with
> > patch 8. It looks funny that you add a driver and then delete a lot of
> > code because you updated some infrastructure later.
>
> The reason for this is to be able to revert generic sdhci changes, in case
> it breaks other drivers, without completly reverting the dwcmshc driver.
> I have only tested the generic changes on the newly added driver.
Please resend the series with first the generic sdhci changes and then
your driver using it. Should we have to revert the generic sdhci changes
then we can still extract the necessary changes to your driver from the
v1 series.
As a reviewer I don't want to review code that is deleted later in the
series.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-07-26 13:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 17:23 [PATCH 1/8] mci: sdhci: Set 8-bit host caps Jules Maselbas
2023-07-10 17:23 ` [PATCH 2/8] mci: sdhci: Add registers defines Jules Maselbas
2023-07-10 17:23 ` [PATCH 3/8] mci: Add dwcmshc-sdhci driver Jules Maselbas
2023-07-10 19:47 ` Sam Ravnborg
2023-07-11 8:12 ` Jules Maselbas
2023-07-26 13:11 ` Sascha Hauer [this message]
2023-07-10 17:23 ` [PATCH 4/8] mci: sdhci: Actually return the error code instead of 0 Jules Maselbas
2023-07-10 17:23 ` [PATCH 5/8] mci: sdhci: Add sd host v4 mode Jules Maselbas
2023-07-10 17:23 ` [PATCH 6/8] mci: sdhci: Add 64-bit DMA addressing suport for V4 mode Jules Maselbas
2023-07-10 17:23 ` [PATCH 7/8] mci: sdhci: Force DMA update to the next block boundary Jules Maselbas
2023-07-11 9:46 ` Jules Maselbas
2023-07-11 13:40 ` [PATCH] fixup! " Jules Maselbas
2023-07-10 17:23 ` [PATCH 8/8] mci: dwcmshc: Use sdhci_enable_v4_mode() Jules Maselbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726131105.GS18491@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jmaselbas@kalray.eu \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox