mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] bootm: export bootm_set_verify_mode
Date: Thu, 27 Jul 2023 08:17:59 +0200	[thread overview]
Message-ID: <20230727061759.ft47w3yqyqqpfzd2@pengutronix.de> (raw)
In-Reply-To: <20230726192824.917472-1-a.fatoum@pengutronix.de>

On 23-07-26, Ahmad Fatoum wrote:
> We already have bootm_get_verify_mode() exported, so export
> bootm_set_verify_mode() for symmetry. The same can already be achieved
> by changing $global.bootm.verify, but direct access makes it easier to
> set a default value that can be overridden by built-in environment.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

> ---
>  common/bootm.c  | 5 +++++
>  include/bootm.h | 1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/common/bootm.c b/common/bootm.c
> index 791d6b8fbbf1..c46b00a86f64 100644
> --- a/common/bootm.c
> +++ b/common/bootm.c
> @@ -70,6 +70,11 @@ enum bootm_verify bootm_get_verify_mode(void)
>  	return bootm_verify_mode;
>  }
>  
> +void bootm_set_verify_mode(enum bootm_verify mode)
> +{
> +	bootm_verify_mode = mode;
> +}
> +
>  static const char * const bootm_verify_names[] = {
>  #ifndef CONFIG_BOOTM_FORCE_SIGNED_IMAGES
>  	[BOOTM_VERIFY_NONE] = "none",
> diff --git a/include/bootm.h b/include/bootm.h
> index 655c5152d97e..ee2b574521db 100644
> --- a/include/bootm.h
> +++ b/include/bootm.h
> @@ -145,6 +145,7 @@ int bootm_load_devicetree(struct image_data *data, void *fdt,
>  int bootm_get_os_size(struct image_data *data);
>  
>  enum bootm_verify bootm_get_verify_mode(void);
> +void bootm_set_verify_mode(enum bootm_verify mode);
>  
>  #define UIMAGE_SOME_ADDRESS (UIMAGE_INVALID_ADDRESS - 1)
>  
> -- 
> 2.39.2
> 
> 
> 



  reply	other threads:[~2023-07-27  6:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 19:28 Ahmad Fatoum
2023-07-27  6:17 ` Marco Felsch [this message]
2023-07-28  5:53 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230727061759.ft47w3yqyqqpfzd2@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox