mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] mci: arasan: Fix reg/val argument swap in register write
@ 2023-08-03  6:59 Sascha Hauer
  0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2023-08-03  6:59 UTC (permalink / raw)
  To: Barebox List

sdhci_write8() takes the register before the value. Fix the argument
order.

The wrong code path is only taken when the xlnx,fails-without-test-cd
property exists which is not the case for any dts file in the tree, so
this bugfix shouldn't have any practical consequences.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mci/arasan-sdhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mci/arasan-sdhci.c b/drivers/mci/arasan-sdhci.c
index 71e974c384..8965acd442 100644
--- a/drivers/mci/arasan-sdhci.c
+++ b/drivers/mci/arasan-sdhci.c
@@ -84,7 +84,7 @@ static int arasan_sdhci_reset(struct arasan_sdhci_host *host, u8 mask)
 
 		ctrl = sdhci_read8(&host->sdhci, SDHCI_HOST_CONTROL);
 		ctrl |= SDHCI_CTRL_CDTEST_INS | SDHCI_CTRL_CDTEST_INS;
-		sdhci_write8(&host->sdhci, ctrl, SDHCI_HOST_CONTROL);
+		sdhci_write8(&host->sdhci, SDHCI_HOST_CONTROL, ctrl);
 	}
 
 	return 0;
-- 
2.39.2




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-08-03  7:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-03  6:59 [PATCH] mci: arasan: Fix reg/val argument swap in register write Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox