From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 31 Aug 2023 16:48:42 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qbiyR-00G3U4-Q1 for lore@lore.pengutronix.de; Thu, 31 Aug 2023 16:48:42 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbiyP-0000zY-JZ for lore@pengutronix.de; Thu, 31 Aug 2023 16:48:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=y8u0obHDBydqmJuTfZBpOGo5LqdNQfdfjUYTDrW52YA=; b=BJwC2Zfk3E07B+0VFImVjiLlDD 9q5HG0hUAqMzFcI27gXlW3dMdAlkSwXri+kZtoI90YKivaSiSL6Novsoeq8ZR8fbmR+fSe/9iYdWE hiP7/sgAWByR0nPgqXGOAQf9LawV2ICZNt551R++DgAeOe3nlQlaGvRCDBF2pSudXRpeyhuKavXhn zAAu0iuHMDSbsC/iEwLVkabPj2HS+uyRamsjHEBSZRV2cOPrJ5VxKCjwJi2foWhS0BsE49o8WnL9a l1GCVZEPchrUwCv2NsUT9nBvzPbJ6Oii104/Vo+pnbRpJF8oMPL/5t7flG5iV1sGX6vBESP48wIOl ZwUC30tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbixG-00FSRP-2V; Thu, 31 Aug 2023 14:47:30 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbixE-00FSQx-0b for barebox@lists.infradead.org; Thu, 31 Aug 2023 14:47:29 +0000 Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qbixC-0000wT-89 for barebox@lists.infradead.org; Thu, 31 Aug 2023 16:47:26 +0200 From: Marco Felsch To: barebox@lists.infradead.org Date: Thu, 31 Aug 2023 16:47:24 +0200 Message-Id: <20230831144724.3424405-1-m.felsch@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230831_074728_229187_98AD0A89 X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2] ARM: i.MX8M: esdctl: split memory banks for devices with >4G X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) At the moment the whole available memory is added to one single memory bank "ram0". This can cause barebox chainload issues on devices with a huge amount of memory like the i.MX8MP-EVK which has 6G of RAM if the barebox pbl binary is to large. The reason for this issues is that memory_bank_first_find_space() returns the memory area with the largest amount of free space on the first memory bank. So in case of Debix SOM-A 8G and i.MX8MP-EVK 6G this is the area crossing the 4G boundary. This cause the barebox pbl code to trigger a MMU exception once the early MMU gets enabled which is configured for sizes <=4G. Split the memory space into two memory banks: "ram0" and "ram1" to fix this issue. Signed-off-by: Marco Felsch --- v2: - drop add_mem() usage and use arm_add_mem_device() directly arch/arm/mach-imx/esdctl.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-imx/esdctl.c b/arch/arm/mach-imx/esdctl.c index 1798ad48e50a..7f313b2337ae 100644 --- a/arch/arm/mach-imx/esdctl.c +++ b/arch/arm/mach-imx/esdctl.c @@ -510,16 +510,31 @@ static resource_size_t imx8m_ddrc_sdram_size(void __iomem *ddrc, unsigned buswid reduced_adress_space, mstr); } +static int _imx8m_ddrc_add_mem(void *mmdcbase, struct imx_esdctl_data *data, + unsigned int buswidth) +{ + resource_size_t size = imx8m_ddrc_sdram_size(mmdcbase, buswidth); + resource_size_t size0, size1; + int ret; + + size0 = min_t(resource_size_t, SZ_4G - MX8M_DDR_CSD1_BASE_ADDR, size); + size1 = size - size0; + + ret = arm_add_mem_device("ram0", data->base0, size0); + if (ret || size1 == 0) + return ret; + + return arm_add_mem_device("ram1", SZ_4G, size1); +} + static int imx8m_ddrc_add_mem(void *mmdcbase, struct imx_esdctl_data *data) { - return arm_add_mem_device("ram0", data->base0, - imx8m_ddrc_sdram_size(mmdcbase, 32)); + return _imx8m_ddrc_add_mem(mmdcbase, data, 32); } static int imx8mn_ddrc_add_mem(void *mmdcbase, struct imx_esdctl_data *data) { - return arm_add_mem_device("ram0", data->base0, - imx8m_ddrc_sdram_size(mmdcbase, 16)); + return _imx8m_ddrc_add_mem(mmdcbase, data, 16); } static resource_size_t imx7d_ddrc_sdram_size(void __iomem *ddrc) -- 2.39.2