mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master] ARM: i.MX8M: romapi: reserve scratch space
Date: Tue,  5 Sep 2023 16:26:48 +0200	[thread overview]
Message-ID: <20230905142648.2936237-1-a.fatoum@pengutronix.de> (raw)

We have 32K of RAM at the end of the initial memory, where a
prebootloader can place data for future use. i.MX8M is currently the
only user and currently uses it to save the ROM API log, which is
located in SRAM and is inaccessible by the time barebox proper runs
in EL2. This area was so far not reserved, which can lead to clobbering
it when chainloading barebox. Avoid this by requesting the region.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/arm/mach-imx/romapi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/mach-imx/romapi.c b/arch/arm/mach-imx/romapi.c
index 2fd803b0d998..aef0ff0534c9 100644
--- a/arch/arm/mach-imx/romapi.c
+++ b/arch/arm/mach-imx/romapi.c
@@ -10,6 +10,8 @@
 #include <mach/imx/xload.h>
 #include <asm/barebox-arm.h>
 #include <zero_page.h>
+#include <memory.h>
+#include <init.h>
 #include <pbl.h>
 
 static int imx8m_bootrom_load(struct rom_api *rom_api, void *adr, size_t size)
@@ -84,6 +86,14 @@ const u32 *imx8m_get_bootrom_log(void)
 	return NULL;
 }
 
+static int imx8m_reserve_scratch_area(void)
+{
+	return PTR_ERR_OR_ZERO(request_sdram_region("scratch area",
+				    (ulong)arm_mem_scratch_get(),
+				    sizeof(struct imx_scratch_space)));
+}
+device_initcall(imx8m_reserve_scratch_area);
+
 void imx8m_save_bootrom_log(void *dest)
 {
 	const u32 *rom_log;
-- 
2.39.2




             reply	other threads:[~2023-09-05 14:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 14:26 Ahmad Fatoum [this message]
2023-09-05 14:35 ` Ahmad Fatoum
2023-09-06 14:16 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230905142648.2936237-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox