mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] fs: ext4: initialize variable to silence GCC false-positive
Date: Mon, 11 Sep 2023 14:25:04 +0200	[thread overview]
Message-ID: <20230911122504.2720431-1-a.fatoum@pengutronix.de> (raw)

GCC complains about ino not being defined in some cases, which appears
to be a false positive. Nevertheless, initialize it to the same fallback
value used in ext4fs_get_ino, which is called below.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 fs/ext4/ext_barebox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/ext_barebox.c b/fs/ext4/ext_barebox.c
index 93dc9b4b1471..df82b629cd05 100644
--- a/fs/ext4/ext_barebox.c
+++ b/fs/ext4/ext_barebox.c
@@ -118,7 +118,7 @@ static struct dentry *ext_lookup(struct inode *dir, struct dentry *dentry,
 				 unsigned int flags)
 {
 	struct ext2fs_node *e2dir = to_ext2_node(dir);
-	int ret, ino;
+	int ret, ino = 0;
 	struct inode *inode;
 
 	ret = ext4fs_get_ino(e2dir, &dentry->d_name, &ino);
-- 
2.39.2




             reply	other threads:[~2023-09-11 12:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 12:25 Ahmad Fatoum [this message]
2023-09-12  8:38 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230911122504.2720431-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox