[PATCH] fs: ext4: initialize variable to silence GCC false-positive

[PATCH] fs: ext4: initialize variable to silence GCC false-positive

[Ahmad Fatoum]

GCC complains about ino not being defined in some cases, which appears
to be a false positive. Nevertheless, initialize it to the same fallback
value used in ext4fs_get_ino, which is called below.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 fs/ext4/ext_barebox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/ext_barebox.c b/fs/ext4/ext_barebox.c
index 93dc9b4b1471..df82b629cd05 100644
--- a/fs/ext4/ext_barebox.c
+++ b/fs/ext4/ext_barebox.c
@@ -118,7 +118,7 @@ static struct dentry *ext_lookup(struct inode *dir, struct dentry *dentry,
 				 unsigned int flags)
 {
 	struct ext2fs_node *e2dir = to_ext2_node(dir);
-	int ret, ino;
+	int ret, ino = 0;
 	struct inode *inode;
 
 	ret = ext4fs_get_ino(e2dir, &dentry->d_name, &ino);
-- 
2.39.2

Re: [PATCH] fs: ext4: initialize variable to silence GCC false-positive

[Sascha Hauer]

On Mon, Sep 11, 2023 at 02:25:04PM +0200, Ahmad Fatoum wrote:
> GCC complains about ino not being defined in some cases, which appears
> to be a false positive. Nevertheless, initialize it to the same fallback
> value used in ext4fs_get_ino, which is called below.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  fs/ext4/ext_barebox.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/fs/ext4/ext_barebox.c b/fs/ext4/ext_barebox.c
> index 93dc9b4b1471..df82b629cd05 100644
> --- a/fs/ext4/ext_barebox.c
> +++ b/fs/ext4/ext_barebox.c
> @@ -118,7 +118,7 @@ static struct dentry *ext_lookup(struct inode *dir, struct dentry *dentry,
>  				 unsigned int flags)
>  {
>  	struct ext2fs_node *e2dir = to_ext2_node(dir);
> -	int ret, ino;
> +	int ret, ino = 0;
>  	struct inode *inode;
>  
>  	ret = ext4fs_get_ino(e2dir, &dentry->d_name, &ino);
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |