mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org, jzi@pengutronix.de
Subject: Re: [PATCH] Documentation: dt-bindings: ocotp: deprecate barebox,provide-mac-address
Date: Tue, 12 Sep 2023 11:27:01 +0200	[thread overview]
Message-ID: <20230912092701.GV637806@pengutronix.de> (raw)
In-Reply-To: <20230911122356.2709296-1-a.fatoum@pengutronix.de>

On Mon, Sep 11, 2023 at 02:23:56PM +0200, Ahmad Fatoum wrote:
> While we'll continue to support barebox,provide-mac-address, new boards
> should prefer using the upstream NVMEM binding for describing the MAC address.
> 
> Add an example to the documentation.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  .../bindings/misc/fsl,imx-ocotp.rst           | 25 ++++++++++++++++---
>  1 file changed, 22 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/Documentation/devicetree/bindings/misc/fsl,imx-ocotp.rst b/Documentation/devicetree/bindings/misc/fsl,imx-ocotp.rst
> index 202bb3aa07ef..1c45267b1b58 100644
> --- a/Documentation/devicetree/bindings/misc/fsl,imx-ocotp.rst
> +++ b/Documentation/devicetree/bindings/misc/fsl,imx-ocotp.rst
> @@ -6,13 +6,14 @@ Required properties:
>  * ``compatible``: ``fsl,imx6q-ocotp``
>  * ``reg``: physical register base and size
>  
> -Optional properties:
> +Deprecated properties:
>  
>  * ``barebox,provide-mac-address``: Provide MAC addresses for Ethernet devices. This
>    can be multiple entries in the form <&phandle regofs> to assign a MAC
> -  address to an Ethernet device.
> +  address to an Ethernet device. This has been deprecated in favor or the upstream
> +  nvmem cell binding.
>  
> -Example:
> +Legacy example:
>  
>  .. code-block:: none
>  
> @@ -21,3 +22,21 @@ Example:
>    	reg = <0x021bc000 0x4000>;
>    	barebox,provide-mac-address = <&fec 0x620>;
>    };
> +
> +Upstream alternative:
> +
> +.. code-block:: none
> +
> +  &ocotp1 {
> +  	#address-cells = <1>;
> +  	#size-cells = <1>;
> +
> +  	fec_mac_addr: mac-addr@88 {
> +  		reg = <0x88 6>;
> +  	};
> +  };
> +
> +  &fec {
> +  	nvmem-cells = <&fec_mac_addr>;
> +  	nvmem-cell-names = "mac-address";
> +  };
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      parent reply	other threads:[~2023-09-12  9:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 12:23 Ahmad Fatoum
2023-09-11 12:29 ` Marco Felsch
2023-09-11 12:36   ` Ahmad Fatoum
2023-09-11 12:41     ` Marco Felsch
2023-09-12  9:27 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230912092701.GV637806@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=jzi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox