mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] globalvar: add a globalvar_get helper
Date: Fri, 6 Oct 2023 13:55:22 +0200	[thread overview]
Message-ID: <20231006115522.GG235829@pengutronix.de> (raw)
In-Reply-To: <20230921141628.277661-1-a.fatoum@pengutronix.de>

On Thu, Sep 21, 2023 at 04:16:28PM +0200, Ahmad Fatoum wrote:
> We have functions to set global variables, but none to get them, but
> having a globalvar_get helper could be useful to get code size down when
> global variables are disabled, as globalvar_get("var") would be optimized
> out, while getenv("global.var") wouldn't. Therefore, add the helper.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  include/globalvar.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/include/globalvar.h b/include/globalvar.h
> index 36a7c7006c76..5fdb70fca911 100644
> --- a/include/globalvar.h
> +++ b/include/globalvar.h
> @@ -10,6 +10,12 @@
>  extern struct device global_device;
>  
>  #ifdef CONFIG_GLOBALVAR
> +
> +static inline const char *globalvar_get(const char *name)
> +{
> +	return dev_get_param(&global_device, name);
> +}
> +
>  int globalvar_add_simple(const char *name, const char *value);
>  
>  void globalvar_remove(const char *name);
> @@ -41,6 +47,11 @@ void dev_param_init_from_nv(struct device *dev, const char *name);
>  void globalvar_alias_deprecated(const char *newname, const char *oldname);
>  
>  #else
> +static inline const char *globalvar_get(const char *name)
> +{
> +	return NULL;
> +}
> +
>  static inline int globalvar_add_simple(const char *name, const char *value)
>  {
>  	return 0;
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      parent reply	other threads:[~2023-10-06 11:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 14:16 Ahmad Fatoum
2023-10-05  6:53 ` Ahmad Fatoum
2023-10-06 11:55 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006115522.GG235829@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox