From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 11/26] ARM: i.MX8M: add flexspi-imx8m{m,p}-cfg.h header
Date: Mon, 16 Oct 2023 07:44:49 +0200 [thread overview]
Message-ID: <20231016054449.xiwwqwrulhv5tfr7@pengutronix.de> (raw)
In-Reply-To: <20231013062749.GK3359458@pengutronix.de>
On 23-10-13, Sascha Hauer wrote:
> On Tue, Oct 10, 2023 at 04:32:59PM +0200, Marco Felsch wrote:
> > Add dedicated configuration headers which guard the flexspi_* options
> > like it is done for the HABV4 configuration block to be more
> > user-friendly.
> >
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> > include/mach/imx/flexspi-imx8mm-cfg.h | 10 ++++++++++
> > include/mach/imx/flexspi-imx8mp-cfg.h | 10 ++++++++++
> > 2 files changed, 20 insertions(+)
> > create mode 100644 include/mach/imx/flexspi-imx8mm-cfg.h
> > create mode 100644 include/mach/imx/flexspi-imx8mp-cfg.h
> >
> > diff --git a/include/mach/imx/flexspi-imx8mm-cfg.h b/include/mach/imx/flexspi-imx8mm-cfg.h
> > new file mode 100644
> > index 000000000000..f7f0310a57f4
> > --- /dev/null
> > +++ b/include/mach/imx/flexspi-imx8mm-cfg.h
> > @@ -0,0 +1,10 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +
> > +/*
> > + * This snippet can be included from a i.MX flash header configuration
> > + * file for generating FlexSPI compatible images.
> > + */
> > +#if defined(CONFIG_SPI_NXP_FLEXSPI)
> > +flexspi_ivtofs 0x1000
> > +flexspi_fcfbofs 0x0
> > +#endif
>
> What's this #ifdef good for?
>
> CONFIG_SPI_NXP_FLEXSPI enables the flexspi driver, but this is not
> necessary to boot from it, right?
The flexspi_* options are used to decide if the barebox image should be
flexspi compatible. It also influence the HAB CSF generation since it
adds a 2nd CSF slot depending if enabled.
We can drop this guard as you already NACKed to use the
CONFIG_SPI_NXP_FLEXSPI for HAB decisions.
Regards,
Marco
>
> Sascha
>
> > diff --git a/include/mach/imx/flexspi-imx8mp-cfg.h b/include/mach/imx/flexspi-imx8mp-cfg.h
> > new file mode 100644
> > index 000000000000..bbc061241748
> > --- /dev/null
> > +++ b/include/mach/imx/flexspi-imx8mp-cfg.h
> > @@ -0,0 +1,10 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +
> > +/*
> > + * This snippet can be included from a i.MX flash header configuration
> > + * file for generating FlexSPI compatible images.
> > + */
> > +#if defined(CONFIG_SPI_NXP_FLEXSPI)
> > +flexspi_ivtofs 0x0
> > +flexspi_fcfbofs 0x400
> > +#endif
> > --
> > 2.39.2
> >
> >
> >
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
next prev parent reply other threads:[~2023-10-16 5:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 14:32 [PATCH 00/26] i.MX8M HAB Fixes Marco Felsch
2023-10-10 14:32 ` [PATCH 01/26] kbuild: clean start*_*.{p,ps}imximg files Marco Felsch
2023-10-10 14:32 ` [PATCH 02/26] i.MX: HABv4: fix event status comparison Marco Felsch
2023-10-10 14:32 ` [PATCH 03/26] i.MX: HABv4: fix i.MX8MQ device lockdown Marco Felsch
2023-10-10 18:35 ` [PATCH] fixup! " Ahmad Fatoum
2023-10-11 5:00 ` Marco Felsch
2023-10-10 14:32 ` [PATCH 04/26] i.MX: HAB: remove unused init() hook Marco Felsch
2023-10-10 14:32 ` [PATCH 05/26] i.MX: HABv4: extend support to i.MX8M SoCs Marco Felsch
2023-10-10 14:32 ` [PATCH 06/26] i.MX: HABv4: retrieve HAB ROM version for i.MX8M Marco Felsch
2023-10-10 14:32 ` [PATCH 07/26] ARM: i.MX: allow HAB for i.MX8M family Marco Felsch
2023-10-10 14:32 ` [PATCH 08/26] ARM: i.MX: introduce build_imx8m_habv4img Marco Felsch
2023-10-10 14:32 ` [PATCH 09/26] ARM: i.MX: convert i.MX8M to helper Marco Felsch
2023-10-10 14:32 ` [PATCH 10/26] ARM: boards: i.MX8M: add HAB image support Marco Felsch
2023-10-10 14:32 ` [PATCH 11/26] ARM: i.MX8M: add flexspi-imx8m{m,p}-cfg.h header Marco Felsch
2023-10-13 6:27 ` Sascha Hauer
2023-10-16 5:44 ` Marco Felsch [this message]
2023-10-10 14:33 ` [PATCH 12/26] ARM: boards: i.MX8M: make use of new " Marco Felsch
2023-10-10 14:33 ` [PATCH 13/26] ARM: lds: introduce HAB_CSF_LEN define for the hab_csf section Marco Felsch
2023-10-10 14:33 ` [PATCH 14/26] ARM: lds: add support for a 2nd CSF area Marco Felsch
2023-10-13 6:37 ` Sascha Hauer
2023-10-16 5:45 ` Marco Felsch
2023-10-10 14:33 ` [PATCH 15/26] scripts: imx: force flexspi and hab option order Marco Felsch
2023-10-10 14:33 ` [PATCH 16/26] scripts: imx: move flexspi_image() into header Marco Felsch
2023-10-10 14:33 ` [PATCH 17/26] scripts: imx: fix i.MX8M CSF header placement Marco Felsch
2023-10-10 14:33 ` [PATCH 18/26] scripts: imx: add imx8m_get_offset_size helper Marco Felsch
2023-10-10 14:33 ` [PATCH 19/26] scripts: imx-image: header_v2: add CSF slots Marco Felsch
2023-10-10 14:33 ` [PATCH 20/26] scripts: imx-image: hab_sign: refactor function Marco Felsch
2023-10-10 14:33 ` [PATCH 21/26] scripts: imx: add helper to write CSF Blocks command Marco Felsch
2023-10-13 7:28 ` Sascha Hauer
2023-10-16 5:50 ` Marco Felsch
2023-10-16 7:44 ` Marco Felsch
2023-10-16 8:19 ` Sascha Hauer
2023-10-17 14:58 ` Marco Felsch
2023-10-10 14:33 ` [PATCH 22/26] scripts: imx: fix HAB for FlexSPI boot Marco Felsch
2023-10-10 14:33 ` [PATCH 23/26] scripts: imx-image: add missing close() Marco Felsch
2023-10-10 14:33 ` [PATCH 24/26] scripts: imx-image: add support for CST_EXTRA_CMDLINE_OPTIONS Marco Felsch
2023-10-10 14:33 ` [PATCH 25/26] Documentation: boards: imx: replace i.MX8MQ with i.MX8M Marco Felsch
2023-10-10 14:33 ` [PATCH 26/26] Documentation: boards: imx: add FlexSPI sub-section Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016054449.xiwwqwrulhv5tfr7@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox