Re: [PATCH 1/2] usb: gadget: initialize serialnumber as empty string

[Marco Felsch <m.felsch@pengutronix.de>]

On 23-10-26, Ahmad Fatoum wrote:
> Hello Marco,
> 
> On 26.10.23 14:46, Marco Felsch wrote:
> > Windows hosts do require the serial number to be set to any ascii string
> > to enumerate correctly. Set the serial number to "empty" to provide a
> > sane default which works for both hosts. Users can still override this
> > via the gadget.serialnumber variable.
> > 
> > Reported-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> >  drivers/usb/gadget/udc/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> > index b58498680ad1..dc5d1daa14bf 100644
> > --- a/drivers/usb/gadget/udc/core.c
> > +++ b/drivers/usb/gadget/udc/core.c
> > @@ -1204,7 +1204,7 @@ int usb_add_gadget(struct usb_gadget *gadget)
> >  	gadget->productname = xstrdup(barebox_get_model());
> >  	dev_add_param_string(&gadget->dev, "productname", NULL, NULL,
> >  			     &gadget->productname, NULL);
> > -	gadget->serialnumber = xstrdup("");
> > +	gadget->serialnumber = xstrdup("empty");
> 
> Given that we initialize productname to model, it makes sense to initialize
> serialnumber to global.serial_number now that we have that generic variable.
> 
> If that's unset, you can use a fixed value, I'd prefer "unset" though
> instead of "empty".

I will adapt it, thanks.

Regards,
  Marco