mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/3] of: early exit of_match_node if no better matches are possible
Date: Tue,  5 Dec 2023 12:36:17 +0100	[thread overview]
Message-ID: <20231205113618.3966168-3-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20231205113618.3966168-1-a.fatoum@pengutronix.de>

The maximum score that can be returned by of_device_is_compatible is
OF_DEVICE_COMPATIBLE_MAX_SCORE. Once that score is returned, there is no
point in continuing with the string comparisons, so just early exit.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/of/base.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 8a42fcee1d40..b22959dabebf 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -717,6 +717,9 @@ const struct of_device_id *of_match_node(const struct of_device_id *matches,
 		if (score > best_score) {
 			best_match = matches;
 			best_score = score;
+
+			if (score == OF_DEVICE_COMPATIBLE_MAX_SCORE)
+				break;
 		}
 	}
 
-- 
2.39.2




  parent reply	other threads:[~2023-12-05 11:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 11:36 [PATCH 0/3] FIT: match best configuration when multiple are compatible Ahmad Fatoum
2023-12-05 11:36 ` [PATCH 1/3] of: define macro for maximum of_device_is_compatible return value Ahmad Fatoum
2023-12-05 11:36 ` Ahmad Fatoum [this message]
2023-12-05 11:36 ` [PATCH 3/3] FIT: match best configuration when multiple are compatible Ahmad Fatoum
2023-12-13  6:44 ` [PATCH 0/3] " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231205113618.3966168-3-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox