mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master] mci: stm32_sdmmc2: fix warnings when building for 64-bit
Date: Fri, 15 Dec 2023 12:01:00 +0100	[thread overview]
Message-ID: <20231215110100.GL1318922@pengutronix.de> (raw)
In-Reply-To: <20231214151529.1650181-1-a.fatoum@pengutronix.de>

On Thu, Dec 14, 2023 at 04:15:29PM +0100, Ahmad Fatoum wrote:
> Building the driver via CONFIG_COMPILE_TEST for 64-bit shows two
> instances of type confusion, fix them.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/mci/stm32_sdmmc2.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Squashed this into "mci: stm32_sdmmc2: correct usage of DMA API"
(currently sitting in next) which breaks it.

Sascha

> 
> diff --git a/drivers/mci/stm32_sdmmc2.c b/drivers/mci/stm32_sdmmc2.c
> index 84969a29d0f4..418213a1b334 100644
> --- a/drivers/mci/stm32_sdmmc2.c
> +++ b/drivers/mci/stm32_sdmmc2.c
> @@ -257,8 +257,8 @@ static void stm32_sdmmc2_pwron(struct stm32_sdmmc2_priv *priv)
>  	udelay(DIV_ROUND_UP(74 * USEC_PER_SEC, priv->mci.clock));
>  }
>  
> -static int stm32_sdmmc2_start_data(struct stm32_sdmmc2_priv *priv,
> -				    struct mci_data *data, u32 data_length)
> +static dma_addr_t stm32_sdmmc2_start_data(struct stm32_sdmmc2_priv *priv,
> +					  struct mci_data *data, u32 data_length)
>  {
>  	unsigned int num_bytes = data->blocks * data->blocksize;
>  	dma_addr_t idmabase0;
> @@ -494,8 +494,8 @@ static int stm32_sdmmc2_send_cmd(struct mci_host *mci, struct mci_cmd *cmd,
>  
>  	stm32_sdmmc2_start_cmd(priv, cmd, cmdat, data_length);
>  
> -	dev_dbg(priv->dev, "%s: send cmd %d data: 0x%x @ 0x%x\n", __func__,
> -		cmd->cmdidx, data ? data_length : 0, (unsigned int)data);
> +	dev_dbg(priv->dev, "%s: send cmd %d data: 0x%x @ %p\n", __func__,
> +		cmd->cmdidx, data ? data_length : 0, data);
>  
>  	ret = stm32_sdmmc2_end_cmd(priv, cmd);
>  
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2023-12-15 11:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 15:15 Ahmad Fatoum
2023-12-15 11:01 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231215110100.GL1318922@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox