mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master 0/7] regmap: fix size of regmap-backed cdev and nvmem
Date: Mon, 8 Jan 2024 10:43:01 +0100	[thread overview]
Message-ID: <20240108094301.GD1318922@pengutronix.de> (raw)
In-Reply-To: <20240102170100.1596372-1-a.fatoum@pengutronix.de>

On Tue, Jan 02, 2024 at 06:00:53PM +0100, Ahmad Fatoum wrote:
> struct regmap::max_register is in units of struct regmap::reg_stride.
> To get the total number or registers, we need to divide by reg_stride
> before adding one, but we ended up adding one before division.
> 
> This is wrong at different places across the tree, leading to the last
> fuse to be inaccessible when not using the regmap API directly, i.e.
> when using a NVMEM registered by nvmem_register_regmap or the cdev
> instantiated in /dev.
> 
> Ahmad Fatoum (6):
>   regmap: fix calculation of regmap size when reg_stride != 1
>   nvmem: bsec: correct regmap's max_register
>   nvmem: startfive-otp: correct regmap's max_register
>   nvmem: imx-ocotp-ele: correct regmap's max_register
>   nvmem: ocotp: correct regmap's max_register
>   nvmem: ocotp: align OCOTP bank count with Linux
> 
> Robin van der Gracht (1):
>   nvmem: regmap: Fix nvmem size

Applied, thanks

Sascha

> 
>  drivers/base/regmap/regmap.c  | 28 ++++++++++++++++++++++++++--
>  drivers/nvmem/bsec.c          |  2 +-
>  drivers/nvmem/imx-ocotp-ele.c |  2 +-
>  drivers/nvmem/ocotp.c         | 24 ++++++++++++------------
>  drivers/nvmem/regmap.c        |  4 ++--
>  drivers/nvmem/starfive-otp.c  |  2 +-
>  6 files changed, 43 insertions(+), 19 deletions(-)
> 
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      parent reply	other threads:[~2024-01-08  9:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02 17:00 Ahmad Fatoum
2024-01-02 17:00 ` [PATCH master 1/7] regmap: fix calculation of regmap size when reg_stride != 1 Ahmad Fatoum
2024-01-02 17:00 ` [PATCH master 2/7] nvmem: bsec: correct regmap's max_register Ahmad Fatoum
2024-01-08 10:29   ` Robin van der Gracht
2024-01-08 10:44     ` Ahmad Fatoum
2024-01-08 11:17       ` Robin van der Gracht
2024-01-08 12:48         ` Robin van der Gracht
2024-01-11  7:35           ` Ahmad Fatoum
2024-01-02 17:00 ` [PATCH master 3/7] nvmem: startfive-otp: " Ahmad Fatoum
2024-01-02 17:00 ` [PATCH master 4/7] nvmem: imx-ocotp-ele: " Ahmad Fatoum
2024-01-02 17:00 ` [PATCH master 5/7] nvmem: ocotp: " Ahmad Fatoum
2024-01-02 17:00 ` [PATCH master 6/7] nvmem: ocotp: align OCOTP bank count with Linux Ahmad Fatoum
2024-01-02 17:01 ` [PATCH master 7/7] nvmem: regmap: Fix nvmem size Ahmad Fatoum
2024-01-08  9:43 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240108094301.GD1318922@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox