From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master v2 1/2] hab: habv4: use explicitly unsigned types for pointers into SRAM
Date: Thu, 11 Jan 2024 14:00:14 +0100 [thread overview]
Message-ID: <20240111130015.1784217-1-a.fatoum@pengutronix.de> (raw)
char is generally unsigned on ARM, but we shouldn't rely on that. HAB
code does though and compare a char against 0xdb, which would never
succeed if chars were signed. Switch to an explicitly unsigned type to
fix this.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
- no change
---
drivers/hab/habv4.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hab/habv4.c b/drivers/hab/habv4.c
index 974158fd0c01..4db1e7cc0f3a 100644
--- a/drivers/hab/habv4.c
+++ b/drivers/hab/habv4.c
@@ -216,11 +216,11 @@ static enum hab_status imx8m_read_sram_events(enum hab_status status,
{
struct hab_event_record *events[10];
int num_events = 0;
- char *sram;
+ u8 *sram;
int i = 0;
int internal_index = 0;
uint16_t ev_len;
- char *end = 0;
+ u8 *end = 0;
struct hab_event_record *search;
if (cpu_is_mx8mq())
--
2.39.2
next reply other threads:[~2024-01-11 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 13:00 Ahmad Fatoum [this message]
2024-01-11 13:00 ` [PATCH master v2 2/2] hab: habv4: warn if more than 10 HAB events are found Ahmad Fatoum
2024-01-11 15:15 ` [PATCH master v2 1/2] hab: habv4: use explicitly unsigned types for pointers into SRAM Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111130015.1784217-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox