From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 2/2] watchdog: imxulp: Fix prescaler setting on i.MX7ulp
Date: Mon, 15 Jan 2024 16:56:15 +0100 [thread overview]
Message-ID: <20240115155615.953954-2-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20240115155615.953954-1-s.hauer@pengutronix.de>
On i.MX7ulp the driver assumes a clock tick rate of 1kHz. This is only
true though when the /256 prescaler is disabled. To fix this we disable
the prescaler on i.MX7ulp while keeping it enabled on i.MX93. We derived
this bug from U-Boot, the Kernel does this correctly and has the same
code as we introduce here now.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/watchdog/imxulp-wdt.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/watchdog/imxulp-wdt.c b/drivers/watchdog/imxulp-wdt.c
index 84d558b812..5a89876175 100644
--- a/drivers/watchdog/imxulp-wdt.c
+++ b/drivers/watchdog/imxulp-wdt.c
@@ -16,14 +16,16 @@
#include <asm/system.h>
struct imxulp_socdata {
+ bool prescaler_enable;
unsigned int rate;
};
struct imxulp_wd {
struct watchdog wd;
void __iomem *base;
- unsigned int rate;
+ bool prescaler_enable;
struct device *dev;
+ const struct imxulp_socdata *socdata;
};
#define REFRESH_WORD0 0xA602 /* 1st refresh word */
@@ -72,10 +74,13 @@ static int imxulp_watchdog_set_timeout(struct watchdog *wd, unsigned int timeout
while (!(readl(imxwd->base + WDOG_CS) & WDOG_CS_ULK))
;
- writel(timeout * imxwd->rate, imxwd->base + WDOG_TOVAL);
+ writel(timeout * imxwd->socdata->rate, imxwd->base + WDOG_TOVAL);
+
+ if (imxwd->socdata->prescaler_enable)
+ cmd32 |= WDOG_CS_PRES;
writel(cmd32 | WDOG_CS_EN | WDOG_CS_UPDATE | WDOG_CS_LPO_CLK |
- WDOG_CS_FLG | WDOG_CS_PRES | WDOG_CS_INT, imxwd->base + WDOG_CS);
+ WDOG_CS_FLG | WDOG_CS_INT, imxwd->base + WDOG_CS);
/* Wait WDOG reconfiguration */
while (!(readl(imxwd->base + WDOG_CS) & WDOG_CS_RCS))
@@ -115,10 +120,10 @@ static int imxulp_wd_probe(struct device *dev)
if (IS_ERR(iores))
return dev_err_probe(dev, PTR_ERR(iores), "could not get memory region\n");
- imxwd->rate = socdata->rate;
+ imxwd->socdata = socdata;
imxwd->base = IOMEM(iores->start);
imxwd->wd.set_timeout = imxulp_watchdog_set_timeout;
- imxwd->wd.timeout_max = 0xffff / imxwd->rate;
+ imxwd->wd.timeout_max = 0xffff / imxwd->socdata->rate;
imxwd->wd.hwdev = dev;
imxwd->wd.running = imxulp_wd_running(imxwd);
@@ -130,10 +135,12 @@ static int imxulp_wd_probe(struct device *dev)
}
static struct imxulp_socdata imx7ulp_wd_socdata = {
+ .prescaler_enable = false,
.rate = CLK_RATE_1KHZ,
};
static struct imxulp_socdata imx93_wd_socdata = {
+ .prescaler_enable = true,
.rate = CLK_RATE_32KHZ,
};
--
2.39.2
next prev parent reply other threads:[~2024-01-15 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 15:56 [PATCH 1/2] watchdog: imxulp: Fix timeout calculation Sascha Hauer
2024-01-15 15:56 ` Sascha Hauer [this message]
2024-01-16 6:53 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240115155615.953954-2-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox